X-Git-Url: https://git.proxmox.com/?p=mirror_edk2.git;a=blobdiff_plain;f=Tools%2FSource%2FFrameworkWizard%2Fsrc%2Forg%2Ftianocore%2Fframeworkwizard%2Fmodule%2Fui%2FModulePCDs.java;h=492b305c7260a1f15208daf6e3f6ab55c50296f0;hp=d87fca0d82f343c7ec77db4c8f436ff10cf813f0;hb=06a19ceec7b8b78f4698073ce4054b26dc4a74bd;hpb=8958113b3a4688530fd9fe3825664c66ff3e62c0

diff --git a/Tools/Source/FrameworkWizard/src/org/tianocore/frameworkwizard/module/ui/ModulePCDs.java b/Tools/Source/FrameworkWizard/src/org/tianocore/frameworkwizard/module/ui/ModulePCDs.java
index d87fca0d82..492b305c72 100644
--- a/Tools/Source/FrameworkWizard/src/org/tianocore/frameworkwizard/module/ui/ModulePCDs.java
+++ b/Tools/Source/FrameworkWizard/src/org/tianocore/frameworkwizard/module/ui/ModulePCDs.java
@@ -14,18 +14,18 @@
  **/
 package org.tianocore.frameworkwizard.module.ui;
 
+import java.awt.Dimension;
 import java.awt.event.ActionEvent;
 import java.awt.event.ComponentEvent;
-import java.awt.event.ItemEvent;
+import java.awt.event.MouseEvent;
 import java.util.Vector;
 
 import javax.swing.JButton;
-import javax.swing.JComboBox;
-import javax.swing.JLabel;
 import javax.swing.JPanel;
 import javax.swing.JScrollPane;
-import javax.swing.JTextArea;
-import javax.swing.JTextField;
+import javax.swing.JTable;
+import javax.swing.ListSelectionModel;
+import javax.swing.event.ListSelectionEvent;
 
 import org.tianocore.PcdCodedDocument;
 import org.tianocore.PcdItemTypes;
@@ -33,17 +33,15 @@ import org.tianocore.ModuleSurfaceAreaDocument.ModuleSurfaceArea;
 import org.tianocore.PcdCodedDocument.PcdCoded;
 import org.tianocore.PcdCodedDocument.PcdCoded.PcdEntry;
 import org.tianocore.frameworkwizard.common.DataType;
-import org.tianocore.frameworkwizard.common.DataValidation;
-import org.tianocore.frameworkwizard.common.EnumerationData;
+import org.tianocore.frameworkwizard.common.IDefaultTableModel;
 import org.tianocore.frameworkwizard.common.Log;
 import org.tianocore.frameworkwizard.common.Tools;
 import org.tianocore.frameworkwizard.common.Identifications.OpeningModuleType;
+import org.tianocore.frameworkwizard.common.ui.IFrame;
 import org.tianocore.frameworkwizard.common.ui.IInternalFrame;
-import org.tianocore.frameworkwizard.common.ui.StarLabel;
-import org.tianocore.frameworkwizard.common.ui.iCheckBoxList.ICheckBoxList;
 import org.tianocore.frameworkwizard.module.Identifications.PcdCoded.PcdCodedIdentification;
 import org.tianocore.frameworkwizard.module.Identifications.PcdCoded.PcdCodedVector;
-import org.tianocore.frameworkwizard.workspace.WorkspaceTools;
+import org.tianocore.frameworkwizard.module.ui.dialog.PCDsDlg;
 
 /**
  The class is used to create, update PCD of MSA/MBD file
@@ -64,32 +62,6 @@ public class ModulePCDs extends IInternalFrame {
     //
     private JPanel jContentPane = null;
 
-    private JLabel jLabelItemType = null;
-
-    private JLabel jLabelC_Name = null;
-
-    private JComboBox jComboBoxItemType = null;
-
-    private JComboBox jComboBoxCName = null;
-
-    private JLabel jLabelDefaultValue = null;
-
-    private JTextField jTextFieldDefaultValue = null;
-
-    private StarLabel jStarLabel1 = null;
-
-    private StarLabel jStarLabel2 = null;
-
-    private StarLabel jStarLabel3 = null;
-
-    private JLabel jLabelHelpText = null;
-
-    private JTextField jTextFieldHelpText = null;
-
-    private JTextArea jTextAreaList = null;
-
-    private JComboBox jComboBoxList = null;
-
     private JButton jButtonAdd = null;
 
     private JButton jButtonRemove = null;
@@ -98,27 +70,13 @@ public class ModulePCDs extends IInternalFrame {
 
     private JScrollPane jScrollPane = null;
 
-    private JScrollPane jScrollPaneList = null;
-
-    private JLabel jLabelTokenSpaceGuid = null;
-
-    private JTextField jTextFieldTokenSpaceGuid = null;
-
-    private JLabel jLabelFeatureFlag = null;
-
-    private JTextField jTextFieldFeatureFlag = null;
-
-    private JLabel jLabelArch = null;
-
-    private ICheckBoxList iCheckBoxListArch = null;
+    private JScrollPane jScrollPaneTable = null;
 
-    private JScrollPane jScrollPaneArch = null;
+    private JTable jTable = null;
 
     //
     // Not used by UI
     //
-    private int intSelectedItemId = 0;
-
     private OpeningModuleType omt = null;
 
     private ModuleSurfaceArea msa = null;
@@ -129,85 +87,9 @@ public class ModulePCDs extends IInternalFrame {
 
     private PcdCodedVector vid = new PcdCodedVector();
 
-    private EnumerationData ed = new EnumerationData();
-    
-    private WorkspaceTools wt = new WorkspaceTools();
+    private IDefaultTableModel model = null;
 
-    /**
-     This method initializes jComboBoxItemType 
-     
-     @return javax.swing.JComboBox jComboBoxItemType
-     
-     **/
-    private JComboBox getJComboBoxItemType() {
-        if (jComboBoxItemType == null) {
-            jComboBoxItemType = new JComboBox();
-            jComboBoxItemType.setBounds(new java.awt.Rectangle(160, 35, 320, 20));
-            jComboBoxItemType.setPreferredSize(new java.awt.Dimension(320, 20));
-        }
-        return jComboBoxItemType;
-    }
-
-    /**
-     This method initializes jTextFieldC_Name 
-     
-     @return javax.swing.JTextField jTextFieldC_Name
-     
-     **/
-    private JComboBox getJComboBoxCName() {
-        if (jComboBoxCName == null) {
-            jComboBoxCName = new JComboBox();
-            jComboBoxCName.setBounds(new java.awt.Rectangle(160, 10, 320, 20));
-            jComboBoxCName.setPreferredSize(new java.awt.Dimension(320, 20));
-        }
-        return jComboBoxCName;
-    }
-
-    /**
-     This method initializes jTextFieldDefaultValue 
-     
-     @return javax.swing.JTextField jTextFieldDefaultValue
-     
-     **/
-    private JTextField getJTextFieldDefaultValue() {
-        if (jTextFieldDefaultValue == null) {
-            jTextFieldDefaultValue = new JTextField();
-            jTextFieldDefaultValue.setBounds(new java.awt.Rectangle(160, 85, 320, 20));
-            jTextFieldDefaultValue.setPreferredSize(new java.awt.Dimension(320, 20));
-        }
-        return jTextFieldDefaultValue;
-    }
-
-    /**
-     * This method initializes jTextFieldHelpText	
-     * 	
-     * @return javax.swing.JTextField	
-     */
-    private JTextField getJTextFieldHelpText() {
-        if (jTextFieldHelpText == null) {
-            jTextFieldHelpText = new JTextField();
-            jTextFieldHelpText.setBounds(new java.awt.Rectangle(160, 110, 320, 20));
-            jTextFieldHelpText.setPreferredSize(new java.awt.Dimension(320, 20));
-        }
-        return jTextFieldHelpText;
-    }
-
-    /**
-     This method initializes jComboBoxFileList 
-     
-     @return javax.swing.JComboBox jComboBoxFileList
-     
-     **/
-    private JComboBox getJComboBoxList() {
-        if (jComboBoxList == null) {
-            jComboBoxList = new JComboBox();
-            jComboBoxList.setBounds(new java.awt.Rectangle(15, 245, 210, 20));
-            jComboBoxList.addItemListener(this);
-            jComboBoxList.addActionListener(this);
-            jComboBoxList.setPreferredSize(new java.awt.Dimension(210, 20));
-        }
-        return jComboBoxList;
-    }
+    private int selectedRow = -1;
 
     /**
      This method initializes jButtonAdd 
@@ -254,27 +136,12 @@ public class ModulePCDs extends IInternalFrame {
             jButtonUpdate = new JButton();
             jButtonUpdate.setBounds(new java.awt.Rectangle(315, 245, 80, 20));
             jButtonUpdate.setPreferredSize(new java.awt.Dimension(80, 20));
-            jButtonUpdate.setText("Update");
+            jButtonUpdate.setText("Edit");
             jButtonUpdate.addActionListener(this);
         }
         return jButtonUpdate;
     }
 
-    /**
-     * This method initializes jScrollPaneFileList   
-     *   
-     * @return javax.swing.JScrollPane   
-     */
-    private JScrollPane getJScrollPaneList() {
-        if (jScrollPaneList == null) {
-            jScrollPaneList = new JScrollPane();
-            jScrollPaneList.setBounds(new java.awt.Rectangle(15, 270, 465, 240));
-            jScrollPaneList.setViewportView(getJTextAreaList());
-            jScrollPaneList.setPreferredSize(new java.awt.Dimension(465, 240));
-        }
-        return jScrollPaneList;
-    }
-
     /**
      This method initializes jScrollPane  
      
@@ -289,133 +156,93 @@ public class ModulePCDs extends IInternalFrame {
     }
 
     /**
-     * This method initializes jTextAreaFileList 
-     *   
-     * @return javax.swing.JTextArea 
-     */
-    private JTextArea getJTextAreaList() {
-        if (jTextAreaList == null) {
-            jTextAreaList = new JTextArea();
-            jTextAreaList.setEditable(false);
-
+     This method initializes jScrollPaneTable    
+     
+     @return javax.swing.JScrollPane 
+     **/
+    private JScrollPane getJScrollPaneTable() {
+        if (jScrollPaneTable == null) {
+            jScrollPaneTable = new JScrollPane();
+            jScrollPaneTable.setBounds(new java.awt.Rectangle(15, 10, 470, 420));
+            jScrollPaneTable.setPreferredSize(new Dimension(470, 420));
+            jScrollPaneTable.setViewportView(getJTable());
         }
-        return jTextAreaList;
+        return jScrollPaneTable;
     }
 
     /**
-     * This method initializes jTextFieldTokenSpaceGuid	
-     * 	
-     * @return javax.swing.JTextField	
-     */
-    private JTextField getJTextFieldTokenSpaceGuid() {
-        if (jTextFieldTokenSpaceGuid == null) {
-            jTextFieldTokenSpaceGuid = new JTextField();
-            jTextFieldTokenSpaceGuid.setBounds(new java.awt.Rectangle(160, 60, 320, 20));
-            jTextFieldTokenSpaceGuid.setPreferredSize(new java.awt.Dimension(320, 20));
+     This method initializes jTable  
+     
+     @return javax.swing.JTable  
+     **/
+    private JTable getJTable() {
+        if (jTable == null) {
+            jTable = new JTable();
+            model = new IDefaultTableModel();
+            jTable = new JTable(model);
+            jTable.setRowHeight(20);
+
+            model.addColumn("Name");
+            model.addColumn("Type");
+            model.addColumn("Value");
+
+            jTable.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
+            jTable.getSelectionModel().addListSelectionListener(this);
+            jTable.getModel().addTableModelListener(this);
+            jTable.addMouseListener(this);
         }
-        return jTextFieldTokenSpaceGuid;
+        return jTable;
     }
 
-    /**
-     * This method initializes jTextFieldFeatureFlag	
-     * 	
-     * @return javax.swing.JTextField	
-     */
-    private JTextField getJTextFieldFeatureFlag() {
-        if (jTextFieldFeatureFlag == null) {
-            jTextFieldFeatureFlag = new JTextField();
-            jTextFieldFeatureFlag.setBounds(new java.awt.Rectangle(160, 135, 320, 20));
-            jTextFieldFeatureFlag.setPreferredSize(new java.awt.Dimension(320, 20));
-        }
-        return jTextFieldFeatureFlag;
+    public static void main(String[] args) {
+
     }
 
     /**
-     This method initializes iCheckBoxListArch   
-
-     @return ICheckBoxList   
+     This method initializes this
+     
      **/
-    private ICheckBoxList getICheckBoxListSupportedArchitectures() {
-        if (iCheckBoxListArch == null) {
-            iCheckBoxListArch = new ICheckBoxList();
-            iCheckBoxListArch.addFocusListener(this);
-            iCheckBoxListArch.setToolTipText(DataType.SUP_ARCH_LIST_HELP_TEXT);
-        }
-        return iCheckBoxListArch;
+    private void init() {
+        this.setSize(500, 515);
+        this.setContentPane(getJScrollPane());
+        this.setTitle("Pcd Coded");
     }
 
     /**
-     This method initializes jScrollPaneArch 
-
-     @return javax.swing.JScrollPane 
+     This method initializes this
+     Fill values to all fields if these values are not empty
+     
+     @param inPackageDependencies
 
      **/
-    private JScrollPane getJScrollPaneArch() {
-        if (jScrollPaneArch == null) {
-            jScrollPaneArch = new JScrollPane();
-            jScrollPaneArch.setBounds(new java.awt.Rectangle(160, 160, 320, 80));
-            jScrollPaneArch.setPreferredSize(new java.awt.Dimension(320, 80));
-            jScrollPaneArch.setViewportView(getICheckBoxListSupportedArchitectures());
-        }
-        return jScrollPaneArch;
-    }
-
-    public static void main(String[] args) {
+    private void init(PcdCoded inPcdCodeds) {
+        init();
+        this.pcds = inPcdCodeds;
+
+        if (this.pcds != null) {
+            if (this.pcds.getPcdEntryList().size() > 0) {
+                for (int index = 0; index < this.pcds.getPcdEntryList().size(); index++) {
+                    String arg0 = pcds.getPcdEntryList().get(index).getCName();
+                    String arg1 = pcds.getPcdEntryList().get(index).getTokenSpaceGuidCName();
+
+                    String arg2 = pcds.getPcdEntryList().get(index).getFeatureFlag();
+                    Vector<String> arg3 = Tools.convertListToVector(pcds.getPcdEntryList().get(index).getSupArchList());
+
+                    String arg4 = pcds.getPcdEntryList().get(index).getDefaultValue();
+                    String arg5 = pcds.getPcdEntryList().get(index).getHelpText();
+                    String arg6 = null;
+                    if (pcds.getPcdEntryList().get(index).getPcdItemType() != null) {
+                        arg6 = pcds.getPcdEntryList().get(index).getPcdItemType().toString();
+                    }
 
+                    id = new PcdCodedIdentification(arg0, arg1, arg2, arg3, arg4, arg5, arg6);
+                    vid.addPcdCoded(id);
+                }
+            }
+        }
+        showTable();
     }
 
-    /**
-    This method initializes this
-    
-    **/
-   private void init() {
-       this.setSize(500, 515);
-       this.setContentPane(getJScrollPane());
-       this.setTitle("Pcd Coded");
-       initFrame();
-       this.setViewMode(false);
-   }
-
-   /**
-    This method initializes this
-    Fill values to all fields if these values are not empty
-    
-    @param inPackageDependencies
-
-    **/
-   private void init(PcdCoded inPcdCodeds) {
-       init();
-       this.pcds = inPcdCodeds;
-
-       if (this.pcds != null) {
-           if (this.pcds.getPcdEntryList().size() > 0) {
-               for (int index = 0; index < this.pcds.getPcdEntryList().size(); index++) {
-                   String arg0 = pcds.getPcdEntryList().get(index).getCName();
-                   String arg1 = pcds.getPcdEntryList().get(index).getTokenSpaceGuidCName();
-                   
-
-                   String arg2 = pcds.getPcdEntryList().get(index).getFeatureFlag();
-                   Vector<String> arg3 = Tools.convertListToVector(pcds.getPcdEntryList().get(index).getSupArchList());
-                   
-                   String arg4 = pcds.getPcdEntryList().get(index).getDefaultValue();
-                   String arg5 = pcds.getPcdEntryList().get(index).getHelpText();
-                   String arg6 = null;
-                   if (pcds.getPcdEntryList().get(index).getPcdItemType() != null) {
-                       arg6 = pcds.getPcdEntryList().get(index).getPcdItemType().toString();
-                   }
-                   
-                   id = new PcdCodedIdentification(arg0, arg1, arg2, arg3, arg4, arg5, arg6);
-                   vid.addPcdCoded(id);
-               }
-           }
-       }
-       //
-       // Update the list
-       //
-       Tools.generateComboBoxByVector(jComboBoxList, vid.getPcdCodedName());
-       reloadListArea();
-   }
-    
     /**
      This is the default constructor
      
@@ -440,19 +267,6 @@ public class ModulePCDs extends IInternalFrame {
         this.setVisible(true);
     }
 
-    /**
-     Disable all components when the mode is view
-     
-     @param isView true - The view mode; false - The non-view mode
-     
-     **/
-    public void setViewMode(boolean isView) {
-        if (isView) {
-            this.jTextFieldDefaultValue.setEnabled(!isView);
-            this.jComboBoxItemType.setEnabled(!isView);
-        }
-    }
-
     /**
      This method initializes jContentPane
      
@@ -461,73 +275,62 @@ public class ModulePCDs extends IInternalFrame {
      **/
     private JPanel getJContentPane() {
         if (jContentPane == null) {
-            jLabelArch = new JLabel();
-            jLabelArch.setBounds(new java.awt.Rectangle(15, 160, 140, 20));
-            jLabelArch.setText("Sup Arch List");
-            jLabelFeatureFlag = new JLabel();
-            jLabelFeatureFlag.setBounds(new java.awt.Rectangle(15, 135, 140, 20));
-            jLabelFeatureFlag.setText("Feature Flag");
-            jLabelTokenSpaceGuid = new JLabel();
-            jLabelTokenSpaceGuid.setBounds(new java.awt.Rectangle(15, 60, 140, 20));
-            jLabelTokenSpaceGuid.setText("Token Space C_Name");
-            jLabelHelpText = new JLabel();
-            jLabelHelpText.setBounds(new java.awt.Rectangle(15, 110, 137, 19));
-            jLabelHelpText.setText("Help Text");
-            jLabelC_Name = new JLabel();
-            jLabelC_Name.setText("C_Name");
-            jLabelC_Name.setBounds(new java.awt.Rectangle(15, 10, 140, 20));
-            jLabelDefaultValue = new JLabel();
-            jLabelDefaultValue.setText("Default Value");
-            jLabelDefaultValue.setBounds(new java.awt.Rectangle(15, 85, 140, 20));
-            jLabelItemType = new JLabel();
-            jLabelItemType.setText("Item Type");
-            jLabelItemType.setBounds(new java.awt.Rectangle(15, 35, 140, 20));
-
             jContentPane = new JPanel();
             jContentPane.setLayout(null);
-            jContentPane.setPreferredSize(new java.awt.Dimension(490, 520));
-
-            jContentPane.add(jLabelItemType, null);
-            jContentPane.add(jLabelC_Name, null);
-            jContentPane.add(getJComboBoxCName(), null);
-            jContentPane.add(jLabelDefaultValue, null);
-            jContentPane.add(getJTextFieldDefaultValue(), null);
-            jContentPane.add(getJComboBoxItemType(), null);
-            jStarLabel1 = new StarLabel();
-            jStarLabel1.setLocation(new java.awt.Point(0, 10));
-            jStarLabel2 = new StarLabel();
-            jStarLabel2.setLocation(new java.awt.Point(0, 35));
-            jStarLabel3 = new StarLabel();
-            jStarLabel3.setLocation(new java.awt.Point(0, 110));
-            jContentPane.add(jStarLabel1, null);
-            jContentPane.add(jStarLabel2, null);
-            jContentPane.add(jStarLabel3, null);
-            jContentPane.add(jLabelHelpText, null);
-            jContentPane.add(getJTextFieldHelpText(), null);
-
-            jContentPane.add(getJComboBoxList(), null);
+            jContentPane.setPreferredSize(new java.awt.Dimension(490, 490));
+
             jContentPane.add(getJButtonAdd(), null);
             jContentPane.add(getJButtonRemove(), null);
             jContentPane.add(getJButtonUpdate(), null);
-            jContentPane.add(getJScrollPaneList(), null);
-            jContentPane.add(jLabelTokenSpaceGuid, null);
-            jContentPane.add(getJTextFieldTokenSpaceGuid(), null);
-            jContentPane.add(jLabelFeatureFlag, null);
-            jContentPane.add(getJTextFieldFeatureFlag(), null);
-            jContentPane.add(jLabelArch, null);
-            jContentPane.add(getJScrollPaneArch(), null);
+            jContentPane.add(getJScrollPaneTable(), null);
         }
         return jContentPane;
     }
 
+    private void showEdit(int index) {
+        PCDsDlg dlg = new PCDsDlg(vid.getPcdCoded(index), new IFrame());
+        int result = dlg.showDialog();
+        if (result == DataType.RETURN_TYPE_OK) {
+            if (index == -1) {
+                this.vid.addPcdCoded(dlg.getId());
+            } else {
+                this.vid.setPcdCoded(dlg.getId(), index);
+            }
+            this.showTable();
+            this.save();
+            dlg.dispose();
+        }
+        if (result == DataType.RETURN_TYPE_CANCEL) {
+            dlg.dispose();
+        }
+    }
+
     /**
-     This method initializes Usage type, Item type and Datum type
+     Clear all table rows
      
      **/
-    private void initFrame() {
-        Tools.generateComboBoxByVector(jComboBoxCName, wt.getAllPcdDeclarationsFromWorkspace());
-        Tools.generateComboBoxByVector(jComboBoxItemType, ed.getVPcdItemTypes());
-        this.iCheckBoxListArch.setAllItems(ed.getVSupportedArchitectures());
+    private void clearAll() {
+        if (model != null) {
+            for (int index = model.getRowCount() - 1; index >= 0; index--) {
+                model.removeRow(index);
+            }
+        }
+    }
+
+    /**
+     Read content of vector and put then into table
+     
+     **/
+    private void showTable() {
+        clearAll();
+
+        if (vid.size() > 0) {
+            for (int index = 0; index < vid.size(); index++) {
+                model.addRow(vid.toStringVector(index));
+            }
+        }
+        this.jTable.repaint();
+        this.jTable.updateUI();
     }
 
     /* (non-Javadoc)
@@ -538,83 +341,27 @@ public class ModulePCDs extends IInternalFrame {
      */
     public void actionPerformed(ActionEvent arg0) {
         if (arg0.getSource() == jButtonAdd) {
-            if (!checkAdd()) {
-                return;
-            }
-            addToList();
-        }
-        if (arg0.getSource() == jButtonRemove) {
-            removeFromList();
+            showEdit(-1);
         }
         if (arg0.getSource() == jButtonUpdate) {
-            if (!checkAdd()) {
+            if (this.selectedRow < 0) {
+                Log.err("Please select one record first.");
                 return;
             }
-            updateForList();
+            showEdit(selectedRow);
         }
-    }
 
-    /**
-     Data validation for all fields
-     
-     @retval true - All datas are valid
-     @retval false - At least one data is invalid
-     
-     **/
-    public boolean checkAdd() {
-        //
-        // Check if all fields have correct data types 
-        //
-
-        //
-        // Check C_Name 
-        //
-        if (!isEmpty(this.jComboBoxCName.getSelectedItem().toString())) {
-            if (!DataValidation.isC_NameType(this.jComboBoxCName.getSelectedItem().toString())) {
-                Log.err("Incorrect data type for C_Name");
-                return false;
-            }
-        }
-        
-        //
-        // Check TokenSpaceGuid
-        //
-        if (!isEmpty(this.jTextFieldTokenSpaceGuid.getText())) {
-            if (!DataValidation.isC_NameType(this.jTextFieldTokenSpaceGuid.getText())) {
-                Log.err("Incorrect data type for Token Space C_Name");
-                return false;
-            }
-        }
-        
-        //
-        // Check DefaultValue
-        //
-        if (!isEmpty(this.jTextFieldDefaultValue.getText())) {
-            if (!DataValidation.isDefaultValueType(this.jTextFieldDefaultValue.getText())) {
-                Log.err("Incorrect data type for Default Value");
-                return false;
+        if (arg0.getSource() == jButtonRemove) {
+            if (jTable.isEditing()) {
+                jTable.getCellEditor().stopCellEditing();
             }
-        }
-        
-        //
-        // Check HelpText
-        //
-        if (isEmpty(this.jTextFieldHelpText.getText())) {
-            Log.err("Help Text couldn't be empty");
-            return false;
-        }
-        
-        //
-        // Check FeatureFlag
-        //
-        if (!isEmpty(this.jTextFieldFeatureFlag.getText())) {
-            if (!DataValidation.isFeatureFlag(this.jTextFieldFeatureFlag.getText())) {
-                Log.err("Incorrect data type for Feature Flag");
-                return false;
+            if (selectedRow > -1) {
+                this.model.removeRow(selectedRow);
+                this.vid.removePcdCoded(selectedRow);
+                selectedRow = -1;
+                this.save();
             }
         }
-        
-        return true;
     }
 
     /**
@@ -640,7 +387,8 @@ public class ModulePCDs extends IInternalFrame {
                     if (!isEmpty(vid.getPcdCoded(index).getFeatureFlag())) {
                         p.setFeatureFlag(vid.getPcdCoded(index).getFeatureFlag());
                     }
-                    if (vid.getPcdCoded(index).getSupArchList() != null && vid.getPcdCoded(index).getSupArchList().size() > 0) {
+                    if (vid.getPcdCoded(index).getSupArchList() != null
+                        && vid.getPcdCoded(index).getSupArchList().size() > 0) {
                         p.setSupArchList(vid.getPcdCoded(index).getSupArchList());
                     }
                     if (!isEmpty(vid.getPcdCoded(index).getValue())) {
@@ -664,6 +412,36 @@ public class ModulePCDs extends IInternalFrame {
         }
     }
 
+    /* (non-Javadoc)
+     * @see javax.swing.event.ListSelectionListener#valueChanged(javax.swing.event.ListSelectionEvent)
+     *
+     */
+    public void valueChanged(ListSelectionEvent arg0) {
+        if (arg0.getValueIsAdjusting()) {
+            return;
+        }
+        ListSelectionModel lsm = (ListSelectionModel) arg0.getSource();
+        if (lsm.isSelectionEmpty()) {
+            return;
+        } else {
+            selectedRow = lsm.getMinSelectionIndex();
+        }
+    }
+
+    /* (non-Javadoc)
+     * @see java.awt.event.MouseListener#mouseClicked(java.awt.event.MouseEvent)
+     *
+     */
+    public void mouseClicked(MouseEvent arg0) {
+        if (arg0.getClickCount() == 2) {
+            if (this.selectedRow < 0) {
+                return;
+            } else {
+                showEdit(selectedRow);
+            }
+        }
+    }
+
     /* (non-Javadoc)
      * @see java.awt.event.ComponentListener#componentResized(java.awt.event.ComponentEvent)
      * 
@@ -675,188 +453,12 @@ public class ModulePCDs extends IInternalFrame {
         int intPreferredWidth = this.getJContentPane().getPreferredSize().width;
         int intPreferredHeight = this.getJContentPane().getPreferredSize().height;
 
-        resizeComponentWidth(jComboBoxCName, intCurrentWidth, intPreferredWidth);
-        resizeComponentWidth(jTextFieldTokenSpaceGuid, intCurrentWidth, intPreferredWidth);
-        resizeComponentWidth(jComboBoxItemType, intCurrentWidth, intPreferredWidth);
-        resizeComponentWidth(jTextFieldDefaultValue, intCurrentWidth, intPreferredWidth);
-        resizeComponentWidth(jTextFieldHelpText, intCurrentWidth, intPreferredWidth);
-        resizeComponentWidth(jTextFieldFeatureFlag, intCurrentWidth, intPreferredWidth);
-        resizeComponentWidth(jScrollPaneArch, intCurrentWidth, intPreferredWidth);
-
-        resizeComponentWidth(jComboBoxList, intCurrentWidth, intPreferredWidth);
-        resizeComponent(jScrollPaneList, intCurrentWidth, intCurrentHeight, intPreferredWidth, intPreferredHeight);
-
-        relocateComponentX(jButtonAdd, intCurrentWidth, intPreferredWidth, DataType.SPACE_TO_RIGHT_FOR_ADD_BUTTON);
-        relocateComponentX(jButtonRemove, intCurrentWidth, intPreferredWidth, DataType.SPACE_TO_RIGHT_FOR_REMOVE_BUTTON);
-        relocateComponentX(jButtonUpdate, intCurrentWidth, intPreferredWidth, DataType.SPACE_TO_RIGHT_FOR_UPDATE_BUTTON);
+        resizeComponent(this.jScrollPaneTable, intCurrentWidth, intCurrentHeight, intPreferredWidth, intPreferredHeight);
+        relocateComponent(this.jButtonAdd, intCurrentWidth, intCurrentHeight, intPreferredWidth, intPreferredHeight,
+                          DataType.SPACE_TO_RIGHT_FOR_ADD_BUTTON, DataType.SPACE_TO_BOTTOM_FOR_ADD_BUTTON);
+        relocateComponent(this.jButtonRemove, intCurrentWidth, intCurrentHeight, intPreferredWidth, intPreferredHeight,
+                          DataType.SPACE_TO_RIGHT_FOR_REMOVE_BUTTON, DataType.SPACE_TO_BOTTOM_FOR_REMOVE_BUTTON);
+        relocateComponent(this.jButtonUpdate, intCurrentWidth, intCurrentHeight, intPreferredWidth, intPreferredHeight,
+                          DataType.SPACE_TO_RIGHT_FOR_UPDATE_BUTTON, DataType.SPACE_TO_BOTTOM_FOR_UPDATE_BUTTON);
     }
-    
-    private PcdCodedIdentification getCurrentPcdCoded() {
-        String arg0 = this.jComboBoxCName.getSelectedItem().toString();
-        String arg1 = this.jTextFieldTokenSpaceGuid.getText();
-        
-
-        String arg2 = this.jTextFieldFeatureFlag.getText();
-        Vector<String> arg3 = this.iCheckBoxListArch.getAllCheckedItemsString();
-        
-        String arg4 = this.jTextFieldDefaultValue.getText();
-        String arg5 = this.jTextFieldHelpText.getText();
-        String arg6 = this.jComboBoxItemType.getSelectedItem().toString();
-        id = new PcdCodedIdentification(arg0, arg1, arg2, arg3, arg4, arg5, arg6);
-        return id;
-    }
-    
-    /**
-    Add current item to Vector
-    
-    **/
-   private void addToList() {
-       intSelectedItemId = vid.size();
-
-       vid.addPcdCoded(getCurrentPcdCoded());
-
-       jComboBoxList.addItem(id.getName());
-       jComboBoxList.setSelectedItem(id.getName());
-
-       //
-       // Reset select item index
-       //
-       intSelectedItemId = vid.size();
-
-       //
-       // Reload all fields of selected item
-       //
-       reloadFromList();
-
-       // 
-       // Save to memory
-       //
-       save();
-   }
-
-   /**
-    Remove current item from Vector
-    
-    **/
-   private void removeFromList() {
-       //
-       // Check if exist items
-       //
-       if (this.vid.size() < 1) {
-           return;
-       }
-
-       int intTempIndex = intSelectedItemId;
-
-       jComboBoxList.removeItemAt(intSelectedItemId);
-
-       vid.removePcdCoded(intTempIndex);
-
-       //
-       // Reload all fields of selected item
-       //
-       reloadFromList();
-
-       // 
-       // Save to memory
-       //
-       save();
-   }
-
-   /**
-    Update current item of Vector
-    
-    **/
-   private void updateForList() {
-       //
-       // Check if exist items
-       //
-       if (this.vid.size() < 1) {
-           return;
-       }
-
-       //
-       // Backup selected item index
-       //
-       int intTempIndex = intSelectedItemId;
-
-       vid.updatePcdCoded(getCurrentPcdCoded(), intTempIndex);
-
-       jComboBoxList.removeAllItems();
-       for (int index = 0; index < vid.size(); index++) {
-           jComboBoxList.addItem(vid.getPcdCoded(index).getName());
-       }
-
-       //
-       // Restore selected item index
-       //
-       intSelectedItemId = intTempIndex;
-
-       //
-       // Reset select item index
-       //
-       jComboBoxList.setSelectedIndex(intSelectedItemId);
-
-       //
-       // Reload all fields of selected item
-       //
-       reloadFromList();
-
-       // 
-       // Save to memory
-       //
-       save();
-   }
-
-   /**
-    Refresh all fields' values of selected item of Vector
-    
-    **/
-   private void reloadFromList() {
-       if (vid.size() > 0) {
-           //
-           // Get selected item index
-           //
-           intSelectedItemId = jComboBoxList.getSelectedIndex();
-
-           this.jComboBoxCName.setSelectedItem(vid.getPcdCoded(intSelectedItemId).getName());
-           this.jTextFieldTokenSpaceGuid.setText(vid.getPcdCoded(intSelectedItemId).getGuid());
-           
-           this.jTextFieldDefaultValue.setText(vid.getPcdCoded(intSelectedItemId).getValue());
-           this.jTextFieldHelpText.setText(vid.getPcdCoded(intSelectedItemId).getHelp());
-           this.jComboBoxItemType.setSelectedItem(vid.getPcdCoded(intSelectedItemId).getType());
-
-           jTextFieldFeatureFlag.setText(vid.getPcdCoded(intSelectedItemId).getFeatureFlag());
-           iCheckBoxListArch.setAllItemsUnchecked();
-           iCheckBoxListArch.initCheckedItem(true, vid.getPcdCoded(intSelectedItemId).getSupArchList());
-
-       } else {
-       }
-
-       reloadListArea();
-   }
-
-   /**
-    Update list area pane via the elements of Vector
-    
-    **/
-   private void reloadListArea() {
-       String strListItem = "";
-       for (int index = 0; index < vid.size(); index++) {
-           strListItem = strListItem + vid.getPcdCoded(index).getName() + DataType.UNIX_LINE_SEPARATOR;
-       }
-       this.jTextAreaList.setText(strListItem);
-   }
-
-   /* (non-Javadoc)
-    * @see java.awt.event.ItemListener#itemStateChanged(java.awt.event.ItemEvent)
-    *
-    * Reflesh the frame when selected item changed
-    * 
-    */
-   public void itemStateChanged(ItemEvent arg0) {
-       if (arg0.getSource() == this.jComboBoxList && arg0.getStateChange() == ItemEvent.SELECTED) {
-           reloadFromList();
-       }
-   }
 }