]> git.proxmox.com Git - mirror_edk2.git/commit - UefiCpuPkg/UefiCpuPkg.dec
UefiCpuPkg: change PcdCpuSmmStackGuard default to TRUE
authorLaszlo Ersek <lersek@redhat.com>
Wed, 1 Jun 2016 17:23:20 +0000 (19:23 +0200)
committerLaszlo Ersek <lersek@redhat.com>
Mon, 6 Jun 2016 08:58:24 +0000 (10:58 +0200)
commit509f8425b75dd0b0698b159db71379f49c36b2fc
tree96f3a5912adb86d0635b6bff00dc0e4269309b69
parentd2970bbc1d88dbde480e7eef57f3ddcedd39ad08
UefiCpuPkg: change PcdCpuSmmStackGuard default to TRUE

This Feature PCD causes PiSmmCpuDxe to catch SMM stack overflow at
runtime, logging a clear error message, and entering a CPU dead loop.
Compared to the chaotic and catastrophic consequences of the stack leaking
into, and corrupting, the SMM page table, a stack guard that is enabled by
default is vastly superior.

We should not require sane platforms to explicitly opt in to this
safeguard; instead, we should require platforms that prefer to live
dangerously to opt out of it.

Stack overflow in SMM might even give rise to security vulnerabilities.

Cc: Jeff Fan <jeff.fan@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Ref: http://thread.gmane.org/gmane.comp.bios.edk2.devel/12864
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1341733
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
UefiCpuPkg/UefiCpuPkg.dec