]> git.proxmox.com Git - mirror_edk2.git/commit - UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c
UefiPayloadPkg/BlSupportDxe: fix ReserveResourceInGcd() calls
authorLaszlo Ersek <lersek@redhat.com>
Fri, 13 Sep 2019 19:06:19 +0000 (21:06 +0200)
committerLaszlo Ersek <lersek@redhat.com>
Wed, 9 Oct 2019 07:40:10 +0000 (09:40 +0200)
commit976d0353a6ce48149039849b52bb67527be5b580
treea4bbc1b5510bf928b5779b952fba775e1d11f315
parent04a0c3e8e1384fc054243b61712a4bd6e454e7df
UefiPayloadPkg/BlSupportDxe: fix ReserveResourceInGcd() calls

The last parameter of ReserveResourceInGcd() is "ImageHandle", forwarded
in turn to gDS->AllocateMemorySpace() or gDS->AllocateIoSpace() as "owner"
image handle.

But BlDxeEntryPoint() passes "SystemTable" as "ImageHandle".

Compilers have not flagged it because EFI_HANDLE (the type of
"ImageHandle") is unfortunately specified as (VOID*), and
(EFI_SYSTEM_TABLE*) converts to (VOID*) silently.

Hand the entry point function's "ImageHandle" parameter to
ReserveResourceInGcd(). This fixes an actual bug.

Cc: Benjamin You <benjamin.you@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Guo Dong <guo.dong@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c