]> git.proxmox.com Git - mirror_edk2.git/commit
ArmPkg/PlatformBootManagerLib: connect non-discoverable USB hosts
authorArd Biesheuvel <ard.biesheuvel@arm.com>
Fri, 22 May 2020 08:40:06 +0000 (10:40 +0200)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sat, 6 Jun 2020 07:49:42 +0000 (07:49 +0000)
commit0ae52d4fd157f7d6047b466f4cf69942dd83232b
treec4249d207a05a09be47a98367c2883c1f6997747
parent8035edbe12f0f2a58e8fa9b06d05c8ee1c69ffae
ArmPkg/PlatformBootManagerLib: connect non-discoverable USB hosts

The way the BDS handles the short-form USB device path of the console
keyboard relies on USB host controllers to be locatable via their PCI
metadata, which implies that these controllers already have a PCI I/O
protocol installed on their handle.

This is not the case for non-discoverable USB host controllers that are
supported by the NonDiscoverable PCI device driver. These controllers
must be connected first, or the BDS will never notice their existence,
and will not enable any USB keyboards connected through them.

Let's work around this by connecting these handles explicitly. This is
a bit of a stopgap, but it is the cleanest way of dealing with this
without violating the UEFI driver model entirely. This ensures that
platforms that do not rely on ConnectAll() will keep working as
expected.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf