]> git.proxmox.com Git - mirror_edk2.git/commit
ShellPkg: acpiview: Remove duplicate ACPI structure size definitions
authorKrzysztof Koch <krzysztof.koch@arm.com>
Thu, 30 Jan 2020 11:42:55 +0000 (19:42 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Wed, 19 Feb 2020 06:01:39 +0000 (06:01 +0000)
commit0b9026a823e01078681a3a9153f17c78afb042dd
tree6579b423eef4f0678b0861d67f92a546c6db07a4
parentc73fce3d1280423212ed9c43bba17ef90363c354
ShellPkg: acpiview: Remove duplicate ACPI structure size definitions

Remove duplicate Generic Address Structure (GAS) and ACPI table header
size definitions. Replace any dependencies with the definitions from
Acpi63.h.

AcpiParser.h redefines the size of Generic Address Structure (GAS) and
the ACPI table header. The motivation is to 'minimise any reference to
the EDK2 ACPI headers in an attempt to provide cross checking'. While
the redefined values are unlikely to change, redefinition causes
unnecessary maintenance overhead for acpiview.

In addition to this, EDK2 ACPI headers are referenced throughout the
entire project, so the assumption should be that the definitions in
these header files are correct.

Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h