]> git.proxmox.com Git - mirror_edk2.git/commit
MdeModulePkg/UdfDxe: Handle dead codes in File.c
authorHao Wu <hao.a.wu@intel.com>
Wed, 10 Oct 2018 13:00:20 +0000 (21:00 +0800)
committerHao Wu <hao.a.wu@intel.com>
Thu, 18 Oct 2018 01:12:51 +0000 (09:12 +0800)
commit11941d3b1bfab594ff108ddbfed61bc31e8eb674
treeba08b12f72dc07a80e81c0d766cf435285baed69
parentf355dd34049c88167768e4a8acf85934aaae2dd2
MdeModulePkg/UdfDxe: Handle dead codes in File.c

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1249

We found potential dead codes within File.c during the code coverage test.

After manual review, we think the below ones are positive reports:

A. In function UdfRead():
  else if (IS_FID_DELETED_FILE (Parent->FileIdentifierDesc)) {
    Status = EFI_DEVICE_ERROR;
  }

A File Identifier Descriptor will be get from the UDF media only by
function ReadDirectoryEntry(). And within this function, all the File
Identifier Descriptor with 'DELETED_FILE' characteristics will be skipped
and will not be returned. Hence, the above codes in function UdfRead()
will never be hit.

This commit will add "ASSERT (FALSE);" before the above line to indicate
this.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Paulo Alcantara <palcantara@suse.de>
Reviewed-by: Star Zeng <star.zeng@intel.com>
MdeModulePkg/Universal/Disk/UdfDxe/File.c