]> git.proxmox.com Git - mirror_edk2.git/commit
Revert "ShellPkg: Move FindFirstCharacter/GetNextParameter to ShellCommandLib"
authorRuiyu Ni <ruiyu.ni@intel.com>
Tue, 23 Aug 2016 02:40:55 +0000 (10:40 +0800)
committerRuiyu Ni <ruiyu.ni@intel.com>
Thu, 25 Aug 2016 05:00:47 +0000 (13:00 +0800)
commit1219c85df42d5c9ed187565328e2f5cead5682ed
tree6966122ca6bd49845e3632aaaab622f4b68d790d
parenta747bc1eecaff7c34afbc7a4acd81a8330e42d0a
Revert "ShellPkg: Move FindFirstCharacter/GetNextParameter to ShellCommandLib"

This reverts commit c0bcd3433f33876c519bf5567e0ab69261b57fe9.
The above commit causes several regression of "echo" command:
1. Double quotes are not being stripped from the final text. UEFI Shell 2.2 section 3.4.5 chops out the quotes.
2. Output redirection is not working as expected. Text is being redirected, but the ‘> …’ text should not be.
3. Inconsistent special character handling.  For example, comments with # seem to be parsed out correctly, but handing of ^ is incorrect.
In summary, ‘echo “You are ^#1” > t.txt’ results in the below content in t.txt:
 “You are ^#1” > t.txt

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Tapan Shah <tapandshah@hpe.com>
ShellPkg/Application/Shell/Shell.c
ShellPkg/Application/Shell/Shell.h
ShellPkg/Application/Shell/ShellParametersProtocol.c
ShellPkg/Application/Shell/ShellParametersProtocol.h
ShellPkg/Include/Library/ShellCommandLib.h
ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c