]> git.proxmox.com Git - mirror_edk2.git/commit
EmbeddedPkg/VirtualRealTimeClockLib: Fix correctness issues
authorPete Batard <pete@akeo.ie>
Mon, 25 Feb 2019 23:52:02 +0000 (23:52 +0000)
committerArd Biesheuvel <ard.biesheuvel@linaro.org>
Tue, 26 Feb 2019 07:32:37 +0000 (08:32 +0100)
commit1342d7679e10b45f0702679b521513804205cdaf
treefb71ca1ac56371a78836d0e889fedac95a7e6dbe
parent9ab4ec5188824170af6b429e5a1c77a2f92fe2d2
EmbeddedPkg/VirtualRealTimeClockLib: Fix correctness issues

LibGetTime():
- Two variables were used for the epoch, where only one should have been [*].
- Also harmonize variable name to match the one used in LibSetTime.
LibSetTime():
- Address possible underflows if time is set to start of epoch.
- Ensure that time being read does actually match time that was manually
  set (plus the time elapsed since), by subtracting number of seconds
  since reset.

[*] This fixes a build breakage, since one of these variables was set but
    never used, triggering a compiler diagnostic at some optimization levels.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard <pete@akeo.ie>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c