ShellPkg/UefiShellLib: drop DeviceHandle param of ShellOpenFileByDevicePath()
authorLaszlo Ersek <lersek@redhat.com>
Wed, 18 Jul 2018 18:25:25 +0000 (20:25 +0200)
committerLaszlo Ersek <lersek@redhat.com>
Thu, 16 Aug 2018 18:02:50 +0000 (20:02 +0200)
commit15d8fe1fee188cd7a9ce1b0e32cbe34cc93f1097
treea3539f7e50d27e10ff5e04eeddf31dc1d758a1e7
parent1bf5007428f741857eaefbacfb6762ce5ea8120d
ShellPkg/UefiShellLib: drop DeviceHandle param of ShellOpenFileByDevicePath()

The ShellOpenFileByDevicePath() API promises to set the DeviceHandle
output parameter to the handle of the filesystem identified by the
FilePath input parameter. However, this doesn't actually happen when the
UEFI Shell 2.0 method is used (which is basically "always" nowadays).

Accordingly, the only caller of ShellOpenFileByDevicePath(), namely
ShellOpenFileByName(), defines a (dummy) local DeviceHandle variable just
so it can call ShellOpenFileByDevicePath().

Remove the useless output parameter.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1008
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
ShellPkg/Include/Library/ShellLib.h
ShellPkg/Library/UefiShellLib/UefiShellLib.c
ShellPkg/Library/UefiShellLib/UefiShellLib.inf