]> git.proxmox.com Git - mirror_edk2.git/commit
NetworkPkg/HttpDxe: Fix build warning error if CHAR8 is unsigned.
authorJiaxin Wu <jiaxin.wu@intel.com>
Tue, 2 Jan 2018 03:29:03 +0000 (11:29 +0800)
committerJiaxin Wu <jiaxin.wu@intel.com>
Wed, 10 Jan 2018 00:32:47 +0000 (08:32 +0800)
commit1e4725e569960b1107c11df6c404312d26129eab
treeb5add4a19ecb3110291ed6008e2238ee01681e8c
parent36c19ee6c7c4455f5de2817052444d1a0dad0e3d
NetworkPkg/HttpDxe: Fix build warning error if CHAR8 is unsigned.

This patch is to fix the compiler warning error: C4245. The issue will happen
if the below build option is enabled:
  *_*_*_CC_FLAGS = -J.

That's because the value of ('A' - 'a') is a negative value, which will
be converted to an unsigned type if CHAR8 is treated as unsigned:
  Src -= ('A' - 'a');

The above issue is also recorded at:
https://bugzilla.tianocore.org/show_bug.cgi?id=815.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
NetworkPkg/HttpDxe/HttpsSupport.c