ShellPkg/TftpDynamicCommand: Fix the potential assertion and memory leak issue.
authorJiaxin Wu <jiaxin.wu@intel.com>
Thu, 26 Apr 2018 06:13:57 +0000 (14:13 +0800)
committerJiaxin Wu <Jiaxin.wu@intel.com>
Fri, 13 Jul 2018 05:45:04 +0000 (13:45 +0800)
commit280f49b81170aee9176a47085b168ff3bc9fd3e7
tree6ed14b51ca4d4be66c194c48701297fb1e4eee2c
parent0c6f94dae5e3ca57fe6093ce2fa4d78fdd061857
ShellPkg/TftpDynamicCommand: Fix the potential assertion and memory leak issue.

This patch is to fix the issue reported from
https://bugzilla.tianocore.org/show_bug.cgi?id=925.

DataSize variable was not assigned the value if ShellOpenFileByName returns error.
In the such a case, it should not be used to FreePages. Instead, DataSize can be
used to record the file size once DownloadFile successfully.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c