]> git.proxmox.com Git - mirror_edk2.git/commit
BaseTools: Fix the bug for Pcd used in command line's override
authorYonghong Zhu <yonghong.zhu@intel.com>
Wed, 24 Oct 2018 06:46:09 +0000 (14:46 +0800)
committerYonghong Zhu <yonghong.zhu@intel.com>
Thu, 25 Oct 2018 07:16:16 +0000 (15:16 +0800)
commit5d54ab94db0308e90a86aee543cb3a07a9c4d2bc
tree9d8ef5869f475077b30044d5adb52f6b42ae4ec8
parent8411c9d5c4400f9d1d12a6593f5e6b99eb681357
BaseTools: Fix the bug for Pcd used in command line's override

V2: remove the not used parameter i

Fix the bug for Pcd used in command line not override the Pcd used
in the [component] driver's sub-section.

Case:
DSC file:
[PcdsFixedAtBuild]
TokenSpaceGuid.PcdTest

[Components]
 TestPkg/TestDriver.inf {
  <PcdsFixedAtBuild>
  TokenSpaceGuid.PcdTest|"b"
  }

build command with --pcd TokenSpaceGuid.PcdTest="AAAABB"

Then we found the Pcd value in the AutoGen.c file is incorrect,
because of the incorrect logic that use the pcd in the [component]
section to re-override it.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
BaseTools/Source/Python/AutoGen/AutoGen.py
BaseTools/Source/Python/Workspace/DscBuildData.py