]> git.proxmox.com Git - mirror_edk2.git/commit
BaseTools:Double carriage return inserted from Trim.py on Python3
authorZhiju Fan <zhijux.fan@intel.com>
Fri, 11 Jan 2019 05:04:44 +0000 (13:04 +0800)
committerFeng, Bob C <bob.c.feng@intel.com>
Fri, 1 Feb 2019 03:09:21 +0000 (11:09 +0800)
commit62cb98c254c8c24f610a427c948ca68ba43d7882
tree358786f7d1d69a7a2f8aa2e632a8d7876830c529
parent31e3eeb5e3d2d0b06416ad90d699de51d8761eda
BaseTools:Double carriage return inserted from Trim.py on Python3

https://bugzilla.tianocore.org/show_bug.cgi?id=1379

Line 208 of BaseTools/Source/Python/Trim/Trim.py uses
'NewLines.append(os.linesep)' to insert a new line into
the list that will be written to the output file.
This causes the '\r\n' inserted with os.linesep to be
written as '\r\r\n', causing some assemblers to error.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
Tested-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
BaseTools/Source/Python/Trim/Trim.py