]> git.proxmox.com Git - mirror_edk2.git/commit
MdeModulePkg NvmExpressDxe: return error code in error path
authorStar Zeng <star.zeng@intel.com>
Mon, 23 Apr 2018 08:13:23 +0000 (16:13 +0800)
committerStar Zeng <star.zeng@intel.com>
Wed, 25 Apr 2018 07:55:45 +0000 (15:55 +0800)
commit67d3e63c2c92dc9729e7f56b4fa8b4b47bfefe73
treeb6d92a5470495a8707fbf8e9ecb49fcd51791698
parent3545488dd64c4bf9e7549d020112342985931ab1
MdeModulePkg NvmExpressDxe: return error code in error path

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=937

In NvmeExpressPassthru.c near line 659:
    Prp = NvmeCreatePrpList (
            PciIo,
            PhyAddr,
            EFI_SIZE_TO_PAGES(Offset + Bytes) - 1,
            &PrpListHost,
            &PrpListNo,
            &MapPrpList
            );
    if (Prp == NULL) {
      goto EXIT;
    }
Status is not set to an error code - Status is initialized to
EFI_SUCCESS, or set by a PciIo->Map to EFI_SUCCESS above this
code. This error path should set Status to an error code before
goto EXIT.

Change-Id: I8a5cdf981aa609534c205d3676395805ac60a003
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c