]> git.proxmox.com Git - mirror_edk2.git/commit
UefiCpuPkg RegisterCpuFeaturesLib: NumberOfCpus may be uninitialized
authorZeng, Star <star.zeng@intel.com>
Thu, 21 Jan 2021 09:39:44 +0000 (17:39 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Thu, 21 Jan 2021 14:30:06 +0000 (14:30 +0000)
commit6c5801be6ef36e35f0b4ff906a4c99d68ca6f69a
treee5e5b6564b7fb1d92ac942c2f77d930214b16b81
parent45962a05da1b61696004ca9acf3afb15d6adefbf
UefiCpuPkg RegisterCpuFeaturesLib: NumberOfCpus may be uninitialized

NumberOfCpus local variable in GetAcpiCpuData will be uninitialized
when CpuS3DataDxe runs before DxeRegisterCpuFeaturesLib (linked by
CpuFeaturesDxe) because there is no code to initialize it at
(AcpiCpuData != NULL) execution path.

The issue is exposed after cefad282fb31aff3e1a6dcbd368cbbffc3fce900
and 38ee7bafa72f58982f99ac6f61eef160f80bad69.
There was negligence in that code review.
One further topic may be "Could EDK2 CI be enhanced to catch this kind
of uninitialized local variable case?". :)

This patch fixes this regression issue.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Star Zeng <star.zeng@intel.com>
Message-Id: <20210121093944.1621-1-star.zeng@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c