]> git.proxmox.com Git - mirror_edk2.git/commit
Revert "ShellPkg: Fix echo to support displaying special characters"
authorRuiyu Ni <ruiyu.ni@intel.com>
Tue, 23 Aug 2016 02:40:02 +0000 (10:40 +0800)
committerRuiyu Ni <ruiyu.ni@intel.com>
Thu, 25 Aug 2016 05:00:42 +0000 (13:00 +0800)
commit8e16ac3d74b635c25ad4d6355947a743a11f9eed
tree464d13a893abf641bb71b64d3bddd5c159aac63b
parentd82d59edb0ec23e6ef708e04a5553ac32f1eb12e
Revert "ShellPkg: Fix echo to support displaying special characters"

This reverts commit 95fc5a877502a6e6324300eed0136243d359fa96.
The above commit causes several regression of "echo" command:
1. Double quotes are not being stripped from the final text. UEFI Shell 2.2 section 3.4.5 chops out the quotes.
2. Output redirection is not working as expected. Text is being redirected, but the ‘> …’ text should not be.
3. Inconsistent special character handling.  For example, comments with # seem to be parsed out correctly, but handing of ^ is incorrect.
In summary, ‘echo “You are ^#1” > t.txt’ results in the below content in t.txt:
 “You are ^#1” > t.txt

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Tapan Shah <tapandshah@hpe.com>
ShellPkg/Library/UefiShellLevel3CommandsLib/Echo.c
ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.uni