]> git.proxmox.com Git - mirror_edk2.git/commit
MdeModulePkg/SerialDxe: Fix not able to change serial attributes
authorPankaj Bansal <pankaj.bansal@nxp.com>
Mon, 18 Sep 2017 07:42:45 +0000 (15:42 +0800)
committerStar Zeng <star.zeng@intel.com>
Tue, 19 Sep 2017 03:02:56 +0000 (11:02 +0800)
commit91cc526b15ffbbbdec5a57906596f37e059f80be
treef734f96c9043accfe7a0ff4ae53d42fcd334b1ee
parent7f2f96f1a8af3c22bdf5d4dccb020846799f7be0
MdeModulePkg/SerialDxe: Fix not able to change serial attributes

Issue : When try to change serial attributes using sermode
command, the default values are set with the execute flow
as below.

The sermode command calls SerialSetAttributes, which sets H/W
attributes of Serial device. After that the SerialIo protocol is
reinstalled, which causes MdeModulePkg/Universal/Console/TerminalDxe
and MdeModulePkg/Universal/Console/ConPlatformDxe drivers' bindings
to stop and then start. This in turn calls SerialReset, which undoes
changes of SerialSetAttributes.

Cause : The SerialReset command resets the attributes' values
to default.
Fix : Serial Reset command should set the attributes which have
been changed by user after calling SerialSetAttributes.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
Regression-tested-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
MdeModulePkg/Universal/SerialDxe/SerialIo.c