]> git.proxmox.com Git - mirror_edk2.git/commit
MdeModulePkg: SmmIplEntry(): don't suppress SMM core startup failure
authorLaszlo Ersek <lersek@redhat.com>
Tue, 12 May 2015 01:48:34 +0000 (01:48 +0000)
committererictian <erictian@Edk2>
Tue, 12 May 2015 01:48:34 +0000 (01:48 +0000)
commitb07ea4c198a4c2e095541902a0119cd384f8491a
tree8d94fd197e0a2a10ee6b1e8ae005861745a49814
parentc1b9129c3c1f09a4847c7ff3179ef2edc475cf56
MdeModulePkg: SmmIplEntry(): don't suppress SMM core startup failure

When the ExecuteSmmCoreFromSmram() function fails, SmmIplEntry()
restores the SMRAM range to EFI_MEMORY_UC. However, it saves the
return value of gDS->SetMemorySpaceAttributes() in the same Status
variable that gDS->contains the return value of ExecuteSmmCoreFromSmram().

Therefore, if gDS->SetMemorySpaceAttributes() succeeds, the failure
of ExecuteSmmCoreFromSmram() is masked, and Bad Things Happen (TM).

Introduce a temporary variable just for the return value of
gDS->SetMemorySpaceAttributes().

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17417 6f19259b-4bc3-4df7-8a09-765794883524
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c