]> git.proxmox.com Git - mirror_edk2.git/commit
OvmfPkg: BDS: drop custom boot timeout, revert to IntelFrameworkModulePkg's
authorLaszlo Ersek <lersek@redhat.com>
Thu, 6 Nov 2014 14:21:15 +0000 (14:21 +0000)
committerlersek <lersek@Edk2>
Thu, 6 Nov 2014 14:21:15 +0000 (14:21 +0000)
commitb1220e28202221fa987492f65f538f7acb8b7e7f
tree203b1cdfdb2e0ff9460b735a666ad6ddd6c0aa5c
parentb90ffb9fc8360345138f50988a8a1bd339f80da1
OvmfPkg: BDS: drop custom boot timeout, revert to IntelFrameworkModulePkg's

PlatformBdsEnterFrontPage() already implements a keypress wait (for
entering the setup utility at boot) with a nice progress bar, only OVMF
has not been using it.

Removing our custom code and utilizing PlatformBdsEnterFrontPage()'s
builtin wait has the following benefits:

- It simplifies OVMF's BDS code.

- Because now we call PlatformBdsEnterFrontPage() unconditionally, it
  actually has a chance to look at the EFI_OS_INDICATIONS_BOOT_TO_FW_UI
  bit of the "OsIndications" variable, improving compliance with the UEFI
  specification. References:
  - https://bugzilla.redhat.com/show_bug.cgi?id=1153927
  - http://thread.gmane.org/gmane.comp.bios.tianocore.devel/10487

- The progress bar looks nice. (And it keeps the earlier behavior intact,
  when the user presses a key on the TianoCore splash screen.)

  In any case, we set the timeout to 0 (which doesn't show the progress
  bar and proceeds to the boot options immediately) in order to keep the
  boot time down.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16310 6f19259b-4bc3-4df7-8a09-765794883524
OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c
OvmfPkg/OvmfPkgIa32.dsc
OvmfPkg/OvmfPkgIa32X64.dsc
OvmfPkg/OvmfPkgX64.dsc