]> git.proxmox.com Git - mirror_edk2.git/commit
MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE
authorSamer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Sun, 20 Dec 2020 13:53:53 +0000 (21:53 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Wed, 6 Jan 2021 05:27:29 +0000 (05:27 +0000)
commitb585238d33855fa1ad2ddf83d3fd38d7d48824a1
treeb15b69e15e6be3e1cc1cf304f9e92db874457193
parent020ec963048340c9eaf9799471167d769239bcfc
MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE

REF: https://github.com/pftf/RPi4/issues/115

GraphicsConsoleDxe defaults the ConOut Mode.CursorVisible to TRUE.
However, the driver never draws the cursor during init. This results
in the first call to disable the cursor (using ConOut->EnableCursor(FALSE))
to actually draw the cursor on the screen, as the logic in FlushCursor
depends on the Mode.CursorVisible state to determine if it should draw or
erase the cursor.

Fix by changing the default CursorVisible in this driver to FALSE.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Reviewed-by: Pete Batard <pete@akeo.ie>
Tested-by: Pete Batard <pete@akeo.ie>
(On an RPi4 platform where we had this annoyance of an unwanted cursor
displaying on top of the platform logo)
MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c