]> git.proxmox.com Git - mirror_edk2.git/commit
NetworkPkg: fix CloseProtocol & UninstallMultipleProtocolInterfaces calls
authorLaszlo Ersek <lersek@redhat.com>
Sat, 7 Sep 2019 12:11:31 +0000 (14:11 +0200)
committerLaszlo Ersek <lersek@redhat.com>
Wed, 9 Oct 2019 07:40:10 +0000 (09:40 +0200)
commitbf7249df9cbd0b5096f8f737b2439b6d17be89c3
treeda4f44629b820202b28748a46d9f208e2c73b178
parentc486a33049bbe59eed99255fa772fba63cdbb73a
NetworkPkg: fix CloseProtocol & UninstallMultipleProtocolInterfaces calls

Both the "ControllerHandle" parameter of CloseProtocol() and the "Handle"
parameter of UninstallMultipleProtocolInterfaces() have type EFI_HANDLE,
not (EFI_HANDLE*).

This patch fixes actual bugs. The issues have been dormant likely because
they are on error paths. (Or, in case of TlsAuthConfigDxe, because the
driver is unloaded likely very infrequently.)

Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
NetworkPkg/DnsDxe/DnsDriver.c
NetworkPkg/IScsiDxe/IScsiConfig.c
NetworkPkg/Ip4Dxe/Ip4Driver.c
NetworkPkg/Ip6Dxe/Ip6Driver.c
NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c
NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.c