]> git.proxmox.com Git - mirror_edk2.git/commit
ShellPkg: Unload image on EFI_SECURITY_VIOLATION
authorDandan Bi <dandan.bi@intel.com>
Wed, 4 Sep 2019 07:41:19 +0000 (15:41 +0800)
committerHao A Wu <hao.a.wu@intel.com>
Wed, 25 Sep 2019 02:03:58 +0000 (10:03 +0800)
commitc671c9106c52f4bd000ab8857eecd19574c70dbd
tree53d216b2a78a324de8b8ab3e64ee1e0af2063866
parent2184ededd36b5221699087a8e084e82ee3b3908a
ShellPkg: Unload image on EFI_SECURITY_VIOLATION

For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
the Image was loaded and an ImageHandle was created with a valid
EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
This follows UEFI Spec.

But if the caller of LoadImage() doesn't have the option to defer
the execution of an image, we can not treat EFI_SECURITY_VIOLATION
like any other LoadImage() error, we should unload image for the
EFI_SECURITY_VIOLATION to avoid resource leak.

This patch is to do error handling for EFI_SECURITY_VIOLATION explicitly
for the callers in ShellPkg which don't have the policy to defer the
execution of the image.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Philippe Mathieu-Daude <philmd@redhat.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1992
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
ShellPkg/Application/Shell/ShellManParser.c
ShellPkg/Library/UefiShellDebug1CommandsLib/LoadPciRom.c
ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c