]> git.proxmox.com Git - mirror_edk2.git/commit
MdePkg/BaseLib: Base64Decode(): don't declare variables in nested blocks
authorLaszlo Ersek <lersek@redhat.com>
Tue, 16 Jul 2019 22:18:51 +0000 (00:18 +0200)
committerLaszlo Ersek <lersek@redhat.com>
Wed, 17 Jul 2019 14:36:57 +0000 (16:36 +0200)
commitcce01f538fb4d6ae8c13c88cfc0d3caf5baca833
treee38687342d527e73046f135aad71638d2ec4148b
parent35e242b698cdc6205e99a6d6a188bf27fecf9fb4
MdePkg/BaseLib: Base64Decode(): don't declare variables in nested blocks

The EDK II C Coding Standards Specification (v2.20) strongly discourages
variable declarations in nested block scope:

5       Source Files
5.4     Code File Structure
5.4.1   Scoping Rules
5.4.1.1 Scope

> Block (local) Scope
>
> [...]
>
> Data declarations may follow the opening brace of a compound statement,
> regardless of nesting depth, and before any code generating statements
> have been entered. Other than at the outermost block of a function body,
> this type of declaration is strongly discouraged.

Hoist such variable declarations in Base64Decode() to the outermost
function scope.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Fixes: 35e242b698cdc6205e99a6d6a188bf27fecf9fb4
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1980
Reported-by: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daude <philmd@redhat.com>
MdePkg/Library/BaseLib/String.c