]> git.proxmox.com Git - mirror_edk2.git/commit
MdeModulePkg: TerminalDxe: avoid checking uninitialized variable
authorStar Zeng <star.zeng@intel.com>
Thu, 26 Nov 2015 08:46:20 +0000 (08:46 +0000)
committerlzeng14 <lzeng14@Edk2>
Thu, 26 Nov 2015 08:46:20 +0000 (08:46 +0000)
commitd9b51b21e7ec6c75ba66a6f7b641f79a09c0bdae
tree7d7957f5a14b104c14f8252e9a5b22ca313e7faa
parent1b96428d92c01383dc437717db679f57cf70d980
MdeModulePkg: TerminalDxe: avoid checking uninitialized variable

The SerialIo->GetControl() function is not required to set the
Control output parameter on error. Make sure we apply the
EFI_SERIAL_INPUT_BUFFER_EMPTY optimization in
TerminalConInTimerHandler() only if the SerialIo->GetControl()
function call set that bit in the Control variable.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Suggested-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18962 6f19259b-4bc3-4df7-8a09-765794883524
MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c