]> git.proxmox.com Git - mirror_edk2.git/commit
EmbeddedPkg: do not ASSERT() on valid external input
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Tue, 5 May 2015 15:51:44 +0000 (15:51 +0000)
committeroliviermartin <oliviermartin@Edk2>
Tue, 5 May 2015 15:51:44 +0000 (15:51 +0000)
commite1455b04126ce034301c81c0665d221af14464c6
treefd4a9c28e2984d728f6021281d8b73622483bd86
parent5a44a766b597e4c9960ac1936e6d18001c5e7ce2
EmbeddedPkg: do not ASSERT() on valid external input

Since ASSERT()s are enabled even on all ArmPlatformPkg RELEASE
builds, ASSERT()ing on a valid FDT header will crash the firmware
if the user selects an incorrect file. Since ASSERT() is meant to
catch internal inconsistencies in the firmware, its use here is
inappropriate.

Instead, handle it as a normal error condition.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17309 6f19259b-4bc3-4df7-8a09-765794883524
EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c