]> git.proxmox.com Git - mirror_edk2.git/commit
ShellPkg/Type.c: Add value check before (LoopVar - 1)
authorZhichao Gao <zhichao.gao@intel.com>
Mon, 15 Jul 2019 06:11:49 +0000 (14:11 +0800)
committerJaben Carsey <jaben.carsey@intel.com>
Fri, 19 Jul 2019 15:32:11 +0000 (08:32 -0700)
commitef2360569d008c440c64d2afd77977861ed0a8df
treee842d64959746db82640048be4596316dcc59c3e
parent5d3ef15da7c36c7eb9568a0d72a3237f8054c1c1
ShellPkg/Type.c: Add value check before (LoopVar - 1)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1964

If the file begin with single line Feed ('\n'), then
"AsciiChar == '\n' && ((CHAR8*)Buffer)[LoopVar-1] != '\r'"
would cause a underflow. Add this condition
"(AsciiChar == '\n' && LoopVar == 0)" before it to make sure
(LoopVar - 1) would never encounter a underflow.

Same change in Unicode section.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Andrew Fish <afish@apple.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Andrew Fish <afish@apple.com>
ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c