]> git.proxmox.com Git - mirror_edk2.git/commit
MdeModulePkg/Usb/EfiKey: Fix endpoint selection
authorMrChromebox <matt.devillier@gmail.com>
Mon, 6 Jan 2020 04:12:05 +0000 (12:12 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Mon, 6 Jan 2020 06:40:28 +0000 (06:40 +0000)
commitf9c2c71ed69ca1d92687a55d3ef947cfb4413b3e
tree339b9d6b1124a52001e9394fa4cbed0a6db4c0a1
parent0286fe8176375feaf4af5ac24f8dc46284451ad5
MdeModulePkg/Usb/EfiKey: Fix endpoint selection

The endpoint selected by the driver needs to not
only be an interrupt type, but have direction IN
as required to set up an asynchronous interrupt transfer.

Currently, the driver assumes that the first INT endpoint
will be of type IN, but that is not true of all devices,
and will silently fail on devices which have the OUT endpoint
before the IN. Adjust the endpoint selection loop to explictly
check for direction IN.

Test: detachable keyboard on Google Pixel Slate now works.

Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: GuoMinJ <newexplorerj@gmail.com>
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c