]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdeModulePkg: SmmLockBox: remove wrong DepEx
authorLaszlo Ersek <lersek@redhat.com>
Wed, 4 Dec 2013 08:19:02 +0000 (08:19 +0000)
committerlzeng14 <lzeng14@6f19259b-4bc3-4df7-8a09-765794883524>
Wed, 4 Dec 2013 08:19:02 +0000 (08:19 +0000)
The SmmLockBox driver in
"MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf" currently
specifies a DepEx on EFI_SMM_SW_DISPATCH2_PROTOCOL.

However, the driver doesn't use this protocol at all, either directly or
indirectly. It calls SmiHandlerRegister()
[MdeModulePkg/Core/PiSmmCore/Smi.c] to register SmmLockBoxHandler()
(which serves LockBox requests).

In turn, the SMM Core function SmiHandlerRegister() is also implemented
without EFI_SMM_SW_DISPATCH2_PROTOCOL.

The DepEx has been present since the initial commit of the SmmLockBox
driver (SVN r12029); it is probably superfluous. Let's remove it.

(Alternatively, we could extend OvmfPkg/EmuSmmDxe to fake this protocol,
and return EFI_UNSUPPORTED when any member is called.)

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14930 6f19259b-4bc3-4df7-8a09-765794883524

MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf

index 529ca77757bc9198432aaf5d3367ddfbdee7492b..1804e8ac39ae7e04719c594010a267b33472e293 100644 (file)
@@ -60,5 +60,4 @@
   gEfiLockBoxProtocolGuid            ## PRODUCED\r
 \r
 [Depex]\r
-  gEfiSmmSwDispatch2ProtocolGuid\r
-\r
+  TRUE\r