]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdePkg/UnitTestBaseLib: Add check for pointer BinData
authorGuomin Jiang <guomin.jiang@intel.com>
Tue, 24 Mar 2020 01:34:20 +0000 (09:34 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fri, 27 Mar 2020 02:03:41 +0000 (02:03 +0000)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2531

AllocatePool may fail and BinData may be invalid, check it before use.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c

index 6f7c31cab417c50b01261d279d64c02f320773a6..8952f9da6c3a0894c75ff21e541def1872e7afe4 100644 (file)
@@ -252,9 +252,11 @@ RfcDecodeTest(
   BinSize = AsciiStrnLenS (binString, MAX_TEST_STRING_SIZE);\r
 \r
   BinData = AllocatePool (BinSize);\r
-  Btc->BufferToFree = BinData;\r
+  UT_ASSERT_NOT_NULL(BinData);\r
 \r
+  Btc->BufferToFree = BinData;\r
   ReturnSize = BinSize;\r
+\r
   Status = Base64Decode (b64String, b64StringLen, BinData, &ReturnSize);\r
 \r
   UT_ASSERT_STATUS_EQUAL (Status, Btc->ExpectedStatus);\r