]> git.proxmox.com Git - mirror_edk2.git/commitdiff
ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()
authorLaszlo Ersek <lersek@redhat.com>
Tue, 18 Oct 2016 10:53:48 +0000 (12:53 +0200)
committerLaszlo Ersek <lersek@redhat.com>
Tue, 18 Oct 2016 17:30:38 +0000 (19:30 +0200)
The destination GUID comes first; from
"MdePkg/Include/Library/BaseMemoryLib.h":

> GUID *
> EFIAPI
> CopyGuid (
>   OUT GUID       *DestinationGuid,
>   IN CONST GUID  *SourceGuid
>   );

Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and
"Guid" is where EfiShellGetGuidFromName() has to propagate that result to.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Tim Lewis <tim.lewis@insyde.com>
Reported-by: Tim Lewis <tim.lewis@insyde.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Tim Lewis <tim.lewis@insyde.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
ShellPkg/Application/Shell/ShellProtocol.c

index 2bc0646b453d6111336fd3aa6c5a6a2bdcbc4bd0..04b66c5acaae349977573b93e696d0a6b7e0efa1 100644 (file)
@@ -2207,7 +2207,7 @@ EfiShellGetGuidFromName(
   Status = GetGuidFromStringName(GuidName, NULL, &NewGuid);\r
 \r
   if (!EFI_ERROR(Status)) {\r
-    CopyGuid(NewGuid, Guid);\r
+    CopyGuid(Guid, NewGuid);\r
   }\r
 \r
   return (Status);\r