BaseTools: Eot tool never populates this dictionary
authorCarsey, Jaben </o=Intel/ou=Americas01/cn=Workers/cn=Carsey, Jaben>
Tue, 3 Apr 2018 21:03:03 +0000 (05:03 +0800)
committerYonghong Zhu <yonghong.zhu@intel.com>
Sun, 8 Apr 2018 06:50:15 +0000 (14:50 +0800)
we initialize this dict and then check it's contents, but never add items.
we can remove it without any effect.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
BaseTools/Source/Python/Eot/Eot.py
BaseTools/Source/Python/Eot/EotGlobalData.py

index c4164199acf3ce972b3072d71d2a2e518d4fa707..45c97bb258f20a66d775eaf1ac9ea642aa18ffd5 100644 (file)
@@ -340,14 +340,6 @@ class Eot(object):
             GuidMacro2 = ''\r
             GuidValue = ''\r
 \r
-            # Find value for hardcode guid macro\r
-            if GuidName in EotGlobalData.gGuidMacroDict:\r
-                GuidMacro = EotGlobalData.gGuidMacroDict[GuidName][0]\r
-                GuidValue = EotGlobalData.gGuidMacroDict[GuidName][1]\r
-                SqlCommand = """update Report set GuidMacro = '%s', GuidValue = '%s' where GuidName = '%s'""" %(GuidMacro, GuidValue, GuidName)\r
-                EotGlobalData.gDb.TblReport.Exec(SqlCommand)\r
-                continue\r
-\r
             # Find guid value defined in Dec file\r
             if GuidName in EotGlobalData.gGuidDict:\r
                 GuidValue = EotGlobalData.gGuidDict[GuidName]\r
index a4654853ab5eacfa5ebfc4bd10813f0043b91936..dea4206e9d487cdd818bf41ef0c7df1828d95a5d 100644 (file)
@@ -72,10 +72,6 @@ gOP_SOURCE_FILES = open(gSOURCE_FILES, 'w+')
 # Dict for GUID found in DEC files\r
 gGuidDict = dict()\r
 \r
-# Dict for hard coded GUID Macros\r
-# {GuidName : [GuidMacro : GuidValue]}\r
-gGuidMacroDict = sdict()\r
-\r
 # Dict for PPI\r
 gPpiList = {}\r
 \r