]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdeModulePkg/UfsPciHc: Avoid overriding return value in BindingStart
authorHao Wu <hao.a.wu@intel.com>
Mon, 24 Apr 2017 05:32:04 +0000 (13:32 +0800)
committerHao Wu <hao.a.wu@intel.com>
Tue, 25 Apr 2017 01:08:33 +0000 (09:08 +0800)
In function UfsHcDriverBindingStart(), the return value 'Status' may be
overridden during the original PCI attributes restore process.

This commit refines the logic to avoid such override.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.c

index 373e55b4c29d204320b55c33995fafb7deb719f8..96cf39adc1991b87abd8fa7931908d6301d875bd 100644 (file)
@@ -671,13 +671,12 @@ Done:
       //\r
       // Restore original PCI attributes\r
       //\r
-      Status = PciIo->Attributes (\r
-                        PciIo,\r
-                        EfiPciIoAttributeOperationSet,\r
-                        Private->PciAttributes,\r
-                        NULL\r
-                        );\r
-      ASSERT_EFI_ERROR (Status);\r
+      PciIo->Attributes (\r
+               PciIo,\r
+               EfiPciIoAttributeOperationSet,\r
+               Private->PciAttributes,\r
+               NULL\r
+               );\r
     }\r
     gBS->CloseProtocol (\r
           Controller,\r