]> git.proxmox.com Git - mirror_edk2.git/commitdiff
BaseTools: remove dict from DscBuildData
authorCarsey, Jaben <jaben.carsey@intel.com>
Fri, 20 Apr 2018 15:51:32 +0000 (23:51 +0800)
committerYonghong Zhu <yonghong.zhu@intel.com>
Thu, 26 Apr 2018 06:43:26 +0000 (14:43 +0800)
the dict is not needed as BaseTools can check the set

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
BaseTools/Source/Python/Workspace/DscBuildData.py

index fdf20f9b09636017624fd6ce86cdb6b4a462b861..335267ebc576bfa7f80422af57cd6b0656af776b 100644 (file)
@@ -1947,13 +1947,11 @@ class DscBuildData(PlatformBuildClassObject):
         InitByteValue = ""\r
         CApp = PcdMainCHeader\r
 \r
-        Includes = {}\r
         IncludeFiles = set()\r
         for PcdName in StructuredPcds:\r
             Pcd = StructuredPcds[PcdName]\r
             for IncludeFile in Pcd.StructuredPcdIncludeFile:\r
-                if IncludeFile not in Includes:\r
-                    Includes[IncludeFile] = True\r
+                if IncludeFile not in IncludeFiles:\r
                     IncludeFiles.add(IncludeFile)\r
                     CApp = CApp + '#include <%s>\n' % (IncludeFile)\r
         CApp = CApp + '\n'\r