]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdeModulePkg SdBlockIoPei: Remove a redundant function
authorshenglei <shenglei.zhang@intel.com>
Wed, 8 Aug 2018 08:17:14 +0000 (16:17 +0800)
committerStar Zeng <star.zeng@intel.com>
Tue, 21 Aug 2018 08:29:06 +0000 (16:29 +0800)
The function SdPeimUnlinkMemBlock that is never called
has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062

v2: Remove the comment that mentioned 'SdPeimUnlinkMemBlock'
within function SdPeimFreeMemPool().

Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c

index 24ad3dc6c21022ace15fb841e8fc45554c0e276b..03b79637165694cb95ca4a646343285446be47ec 100644 (file)
@@ -219,31 +219,7 @@ SdPeimIsMemBlockEmpty (
   return TRUE;\r
 }\r
 \r
-/**\r
-  Unlink the memory block from the pool's list.\r
-\r
-  @param  Head           The block list head of the memory's pool.\r
-  @param  BlockToUnlink  The memory block to unlink.\r
 \r
-**/\r
-VOID\r
-SdPeimUnlinkMemBlock (\r
-  IN SD_PEIM_MEM_BLOCK      *Head,\r
-  IN SD_PEIM_MEM_BLOCK      *BlockToUnlink\r
-  )\r
-{\r
-  SD_PEIM_MEM_BLOCK         *Block;\r
-\r
-  ASSERT ((Head != NULL) && (BlockToUnlink != NULL));\r
-\r
-  for (Block = Head; Block != NULL; Block = Block->Next) {\r
-    if (Block->Next == BlockToUnlink) {\r
-      Block->Next         = BlockToUnlink->Next;\r
-      BlockToUnlink->Next = NULL;\r
-      break;\r
-    }\r
-  }\r
-}\r
 \r
 /**\r
   Initialize the memory management pool for the host controller.\r
@@ -305,8 +281,6 @@ SdPeimFreeMemPool (
 \r
   //\r
   // Unlink all the memory blocks from the pool, then free them.\r
-  // SdPeimUnlinkMemBlock can't be used to unlink and free the\r
-  // first block.\r
   //\r
   for (Block = Pool->Head->Next; Block != NULL; Block = Pool->Head->Next) {\r
     SdPeimFreeMemBlock (Pool, Block);\r