1. Remove some unuseful import in Framework's EfiRomTask.java, FlashMapTask.java...
authorqouyang <qouyang@6f19259b-4bc3-4df7-8a09-765794883524>
Fri, 29 Sep 2006 10:00:39 +0000 (10:00 +0000)
committerqouyang <qouyang@6f19259b-4bc3-4df7-8a09-765794883524>
Fri, 29 Sep 2006 10:00:39 +0000 (10:00 +0000)
2. For "BASE" type , the definition of variable "gEfiCallerIdGuid" in Autogen.c is as type of "GUID" instead of "EFI_GUID".

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@1646 6f19259b-4bc3-4df7-8a09-765794883524

Tools/Source/FrameworkTasks/org/tianocore/framework/tasks/EfiRomTask.java
Tools/Source/FrameworkTasks/org/tianocore/framework/tasks/FlashMapTask.java
Tools/Source/FrameworkTasks/org/tianocore/framework/tasks/GenFvImageTask.java
Tools/Source/FrameworkTasks/org/tianocore/framework/tasks/GenSectionTask.java
Tools/Source/FrameworkTasks/org/tianocore/framework/tasks/MakeDeps.java
Tools/Source/GenBuild/org/tianocore/build/autogen/AutoGen.java

index caa7747..acfb2ba 100644 (file)
 package org.tianocore.framework.tasks;\r
 \r
 import java.io.File;\r
-import java.io.InputStreamReader;\r
-import java.util.ArrayList;\r
-import java.util.Iterator;\r
 import java.util.LinkedList;\r
-import java.util.List;\r
 \r
 import org.apache.tools.ant.BuildException;\r
 import org.apache.tools.ant.Project;\r
@@ -31,8 +27,6 @@ import org.apache.tools.ant.taskdefs.Execute;
 import org.apache.tools.ant.taskdefs.LogStreamHandler;\r
 import org.apache.tools.ant.types.Commandline;\r
 \r
-import com.sun.org.apache.bcel.internal.generic.NEW;\r
-\r
 /**\r
   SecFixupTask class.\r
  \r
index c6f5099..9a3c61e 100644 (file)
@@ -629,7 +629,6 @@ public class FlashMapTask extends Task implements EfiDefine {
     private boolean isUptodate() {\r
         long srcTimeStamp = 0;\r
         String srcName = "";\r
-        long dstTimeStamp = 0;\r
         String dstName = "";\r
         long timeStamp = 0;\r
 \r
index d37156d..0f25032 100644 (file)
@@ -23,13 +23,10 @@ import org.apache.tools.ant.taskdefs.LogStreamHandler;
 import org.apache.tools.ant.types.Commandline;\r
 \r
 import java.io.File;\r
-import java.io.InputStreamReader;\r
-import java.lang.ProcessBuilder;\r
 import java.util.LinkedList;\r
 import java.util.regex.Matcher;\r
 import java.util.regex.Pattern;\r
 import java.util.List;\r
-import java.util.StringTokenizer;\r
 import java.util.Iterator;\r
 import java.io.BufferedReader;\r
 import java.io.FileReader;\r
index 4cd7a96..e329c0e 100644 (file)
@@ -364,7 +364,7 @@ public class GenSectionTask extends Task implements EfiDefine, Section, FfsTypes
                     }\r
                 }\r
             } catch (Exception e) {\r
-                throw new BuildException("compress.toBuffer failed!\n");\r
+                throw new BuildException("GenSection<SectionType=EFI_SECTION_COMPRESSION> to Buffer  failed!\n");\r
             } \r
         } else {\r
             Section sect;\r
index 1486bd3..8f5664f 100644 (file)
@@ -18,8 +18,6 @@ import java.io.File;
 import java.io.FileReader;\r
 import java.io.IOException;\r
 import java.io.LineNumberReader;\r
-import java.util.ArrayList;\r
-import java.util.Iterator;\r
 import java.util.List;\r
 \r
 import org.apache.tools.ant.BuildException;\r
@@ -28,7 +26,6 @@ import org.apache.tools.ant.Task;
 import org.apache.tools.ant.taskdefs.Execute;\r
 import org.apache.tools.ant.taskdefs.LogStreamHandler;\r
 import org.apache.tools.ant.types.Commandline;\r
-import org.apache.tools.ant.types.Path;\r
 \r
 import org.tianocore.common.logger.EdkLog;\r
 import org.tianocore.common.cache.FileTimeStamp;\r
index d0d04b3..0d757b9 100644 (file)
@@ -452,9 +452,14 @@ public class AutoGen {
         // Write Guid to autogen.c\r
         //\r
         String guid = CommonDefinition.formatGuidName(saq.getModuleGuid());\r
-\r
-        fileBuffer\r
-        .append("GLOBAL_REMOVE_IF_UNREFERENCED EFI_GUID gEfiCallerIdGuid = {");\r
+        if (this.moduleId.getModuleType().equalsIgnoreCase(EdkDefinitions.MODULE_TYPE_BASE)) {\r
+                       fileBuffer\r
+            .append("GLOBAL_REMOVE_IF_UNREFERENCED GUID gEfiCallerIdGuid = {");\r
+               } else {\r
+                       fileBuffer\r
+            .append("GLOBAL_REMOVE_IF_UNREFERENCED EFI_GUID gEfiCallerIdGuid = {");\r
+               }\r
+        \r
         if (guid == null) {\r
             throw new AutoGenException("Guid value must set!\n");\r
         }\r