EmbeddedPkg/RealTimeClockRuntimeDxe: Drop ASSERTs on function arguments

ASSERT in SetTime_Conf Consistency Test.
SCT Test expect return as Invalid Parameter.
So removed ASSERT().

While at it, check that the NanoSecond field is within the range given
by the UEFI specification.

Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
index 08fb9b0100b6690b4270fba13b154dc94a3e4089..20f1fa640ecc54a7c2974d76d434dbb14b7379c5 100644 (file)
--- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
+++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
@@ -85,10 +85,6 @@ IsDayValid (
   IN  EFI_TIME  *Time\r
   )\r
 {\r
-  ASSERT (Time->Day >= 1);\r
-  ASSERT (Time->Day <= mDayOfMonth[Time->Month - 1]);\r
-  ASSERT (Time->Month != 2 || IsLeapYear (Time) || Time->Day <= 28);\r
-\r
   if (Time->Day < 1 ||\r
       Time->Day > mDayOfMonth[Time->Month - 1] ||\r
       (Time->Month == 2 && !IsLeapYear (Time) && Time->Day > 28)) {\r
@@ -113,6 +109,7 @@ IsTimeValid(
       Time->Hour   > 23                 ||\r
       Time->Minute > 59                 ||\r
       Time->Second > 59                 ||\r
+      Time->Nanosecond > 999999999      ||\r
       !IsValidTimeZone (Time->TimeZone) ||\r
       !IsValidDaylight (Time->Daylight)) {\r
     return FALSE;\r