]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdeModulePkg: Update RuntimeDxe Crc32 to check the input parameter
authorLiming Gao <liming.gao@intel.com>
Thu, 12 Oct 2017 04:22:57 +0000 (12:22 +0800)
committerLiming Gao <liming.gao@intel.com>
Mon, 16 Oct 2017 03:23:07 +0000 (11:23 +0800)
This is the regression issue. After apply CalculateCrc32(), the parameter
check is missing.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Wu Hao A <hao.a.wu@intel.com>
MdeModulePkg/Core/RuntimeDxe/Crc32.c

index 3e91e0804965c43429aed2c55fee41290253a701..c271856015bef1deda3bc813865380b517b5d5c4 100644 (file)
@@ -42,6 +42,10 @@ RuntimeDriverCalculateCrc32 (
   OUT UINT32  *CrcOut\r
   )\r
 {\r
+  if (Data == NULL || DataSize == 0 || CrcOut == NULL) {\r
+    return EFI_INVALID_PARAMETER;\r
+  }\r
+\r
   *CrcOut = CalculateCrc32 (Data, DataSize);\r
   return EFI_SUCCESS;\r
 }\r