FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2.

https://bugzilla.tianocore.org/show_bug.cgi?id=2515

Change the FmpDevicePkg to match the ECC check rule

Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>

diff --git a/FmpDevicePkg/FmpDxe/Dependency.c b/FmpDevicePkg/FmpDxe/Dependency.c
index b63a36b9898afb572a58070b18e6e8680af841ee..8f97c429162e29e0e89d934bcbd08a6e6420d597 100644 (file)
--- a/FmpDevicePkg/FmpDxe/Dependency.c
+++ b/FmpDevicePkg/FmpDxe/Dependency.c
@@ -163,8 +163,8 @@ Push (
 /**\r
   Pop an element from the stack.\r
 \r
-  @param[in]  Value                  Element to pop.\r
-  @param[in]  Type                   Type of element.\r
+  @param[out]  Element                Element to pop.\r
+  @param[in]   Type                   Type of element.\r
 \r
   @retval EFI_SUCCESS            The value was popped onto the stack.\r
   @retval EFI_ACCESS_DENIED      The pop operation underflowed the stack.\r

diff --git a/FmpDevicePkg/FmpDxe/Dependency.h b/FmpDevicePkg/FmpDxe/Dependency.h
index a2aaaceeae6b870cefc522e214148ddfa8048df8..badd2542d68ebaa9acf58f2dc9a687ddccdab8af 100644 (file)
--- a/FmpDevicePkg/FmpDxe/Dependency.h
+++ b/FmpDevicePkg/FmpDxe/Dependency.h
@@ -56,7 +56,7 @@ EvaluateImageDependencies (
   IN CONST EFI_GUID                ImageTypeId,\r
   IN CONST UINT32                  Version,\r
   IN CONST EFI_FIRMWARE_IMAGE_DEP  *Dependencies,\r
-  IN CONST UINT32                  DependenciesSize,\r
+  IN CONST UINT32                  DepexSize,\r
   OUT BOOLEAN                      *IsSatisfied\r
   );\r
 \r

diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index aa92331966c0ae9285573f9650882da5ae19faf8..5b523291e4d7e60fd0b666ea0e44b6470df29d82 100644 (file)
--- a/FmpDevicePkg/FmpDxe/FmpDxe.c
+++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -413,7 +413,7 @@ PopulateDescriptor (
     }\r
     if (!EFI_ERROR (Status) && Image != NULL) {\r
       IsDepexValid = ValidateImageDepex ((EFI_FIRMWARE_IMAGE_DEP *) Image, ImageSize, &DepexSize);\r
-      if (IsDepexValid == TRUE) {\r
+      if (IsDepexValid) {\r
         Private->Descriptor.Dependencies = AllocatePool (DepexSize);\r
         if (Private->Descriptor.Dependencies != NULL) {\r
           CopyMem (Private->Descriptor.Dependencies->Dependencies, Image, DepexSize);\r