MdeModulePkg Tcp4Dxe: Remove redundant functions

The functions that are never called have been removed.
They are SockRcvdErr,SockGroup and TcpPawsOK.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062

Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c b/MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c
index 0476077c2019837884acf0ad99f268326a357bd7..adb5aa35cdf20771db9c6dcdcd18c9b5109e3130 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c
@@ -1107,41 +1107,6 @@ SockGetFreeSpace (
 }\r
 \r
 \r
-/**\r
-  Signal the receive token with the specific error or\r
-  set socket error code after error is received.\r
-\r
-  @param  Sock                  Pointer to the socket.\r
-  @param  Error                 The error code received.\r
-\r
-**/\r
-VOID\r
-SockRcvdErr (\r
-  IN OUT SOCKET       *Sock,\r
-  IN     EFI_STATUS   Error\r
-  )\r
-{\r
-  SOCK_TOKEN  *SockToken;\r
-\r
-  if (!IsListEmpty (&Sock->RcvTokenList)) {\r
-\r
-    SockToken = NET_LIST_HEAD (\r
-                  &Sock->RcvTokenList,\r
-                  SOCK_TOKEN,\r
-                  TokenList\r
-                  );\r
-\r
-    RemoveEntryList (&SockToken->TokenList);\r
-\r
-    SIGNAL_TOKEN (SockToken->Token, Error);\r
-\r
-    FreePool (SockToken);\r
-  } else {\r
-\r
-    SOCK_ERROR (Sock, Error);\r
-  }\r
-}\r
-\r
 \r
 /**\r
   Called by the low layer protocol to indicate that there will be no more data\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/SockInterface.c b/MdeModulePkg/Universal/Network/Tcp4Dxe/SockInterface.c
index 6dbabc4e51cf1329765e106cf5370b3b96071a52..cd20b8bcb2dd14cbb76126681ef54f8b112b07a1 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/SockInterface.c
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/SockInterface.c
@@ -938,48 +938,7 @@ SockGetMode (
 }\r
 \r
 \r
-/**\r
-  Configure the low level protocol to join a multicast group for\r
-  this socket's connection.\r
-\r
-  @param  Sock                 Pointer to the socket of the connection to join the\r
-                               specific multicast group.\r
-  @param  GroupInfo            Pointer to the multicast group info.\r
-\r
-  @retval EFI_SUCCESS          The configuration is done successfully.\r
-  @retval EFI_ACCESS_DENIED    Failed to get the lock to access the socket.\r
-  @retval EFI_NOT_STARTED      The socket is not configured.\r
-\r
-**/\r
-EFI_STATUS\r
-SockGroup (\r
-  IN SOCKET *Sock,\r
-  IN VOID   *GroupInfo\r
-  )\r
-{\r
-  EFI_STATUS  Status;\r
-\r
-  Status = EfiAcquireLockOrFail (&(Sock->Lock));\r
-\r
-  if (EFI_ERROR (Status)) {\r
 \r
-    DEBUG ((EFI_D_ERROR, "SockGroup: Get the access for socket"\r
-      " failed with %r", Status));\r
-\r
-    return EFI_ACCESS_DENIED;\r
-  }\r
-\r
-  if (SOCK_IS_UNCONFIGURED (Sock)) {\r
-    Status = EFI_NOT_STARTED;\r
-    goto Exit;\r
-  }\r
-\r
-  Status = Sock->ProtoHandler (Sock, SOCK_GROUP, GroupInfo);\r
-\r
-Exit:\r
-  EfiReleaseLock (&(Sock->Lock));\r
-  return Status;\r
-}\r
 \r
 \r
 /**\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h b/MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h
index 7ff2fc565edd7a6bb4267f8f5ecd3111d3d2dc81..650a7dd8651f794ec7a22f571e1a594b971aa75e 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h
@@ -550,19 +550,6 @@ SockClone (
   IN SOCKET *Sock\r
   );\r
 \r
-/**\r
-  Signal the receive token with the specific error or\r
-  set socket error code after error is received.\r
-\r
-  @param  Sock                  Pointer to the socket.\r
-  @param  Error                 The error code received.\r
-\r
-**/\r
-VOID\r
-SockRcvdErr (\r
-  IN OUT SOCKET       *Sock,\r
-  IN     EFI_STATUS   Error\r
-  );\r
 \r
 ///\r
 /// Proto type of the create callback\r
@@ -909,25 +896,6 @@ SockGetMode (
   IN OUT VOID   *Mode\r
   );\r
 \r
-/**\r
-  Configure the low level protocol to join a multicast group for\r
-  this socket's connection.\r
-\r
-  @param  Sock                 Pointer to the socket of the connection to join the\r
-                               specific multicast group.\r
-  @param  GroupInfo            Pointer to the multicast group info.\r
-\r
-  @retval EFI_SUCCESS          The configuration is done successfully.\r
-  @retval EFI_ACCESS_DENIED    Failed to get the lock to access the socket.\r
-  @retval EFI_NOT_STARTED      The socket is not configured.\r
-\r
-**/\r
-EFI_STATUS\r
-SockGroup (\r
-  IN SOCKET *Sock,\r
-  IN VOID   *GroupInfo\r
-  );\r
-\r
 /**\r
   Add or remove route information in IP route table associated\r
   with this socket.\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.c b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.c
index 2817b80295874621c0d20240a82717ea7530d33e..e84310f6c6936ae79893a8a2a0d0cac79f4f8d17 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.c
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.c
@@ -350,31 +350,3 @@ TcpParseOption (
 }\r
 \r
 \r
-/**\r
-  Check the segment against PAWS.\r
-\r
-  @param  Tcb     Pointer to the TCP_CB of this TCP instance.\r
-  @param  TSVal   The timestamp value.\r
-\r
-  @retval 1       The segment passed the PAWS check.\r
-  @retval 0       The segment failed to pass the PAWS check.\r
-\r
-**/\r
-UINT32\r
-TcpPawsOK (\r
-  IN TCP_CB *Tcb,\r
-  IN UINT32 TSVal\r
-  )\r
-{\r
-  //\r
-  // PAWS as defined in RFC1323, buggy...\r
-  //\r
-  if (TCP_TIME_LT (TSVal, Tcb->TsRecent) &&\r
-      TCP_TIME_LT (Tcb->TsRecentAge + TCP_PAWS_24DAY, mTcpTick)) {\r
-\r
-    return 0;\r
-\r
-  }\r
-\r
-  return 1;\r
-}\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.h b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.h
index 5185aecea8e0157d52dc86ddd2fecc58a04dbecd..f9782cb598014b727ba56e7d3d765bd56f9ab4a2 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.h
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.h
@@ -126,20 +126,5 @@ TcpParseOption (
   IN OUT TCP_OPTION *Option\r
   );\r
 \r
-/**\r
-  Check the segment against PAWS.\r
-\r
-  @param  Tcb     Pointer to the TCP_CB of this TCP instance.\r
-  @param  TSVal   The timestamp value.\r
-\r
-  @retval 1       The segment passed the PAWS check.\r
-  @retval 0       The segment failed to pass the PAWS check.\r
-\r
-**/\r
-UINT32\r
-TcpPawsOK (\r
-  IN TCP_CB *Tcb,\r
-  IN UINT32 TSVal\r
-  );\r
 \r
 #endif\r