OvmfPkg: BDS: optimize second argument in PlatformBdsEnterFrontPage() call
authorLaszlo Ersek <lersek@redhat.com>
Thu, 6 Nov 2014 14:21:03 +0000 (14:21 +0000)
committerlersek <lersek@Edk2>
Thu, 6 Nov 2014 14:21:03 +0000 (14:21 +0000)
The second parameter of said function is "ConnectAllHappened", and if set
to TRUE, the function sets "gConnectAllHappened" to TRUE.

This global variable in turn controls whether Intel BDS code *itself*
calls BdsLibConnectAllDriversToAllControllers() in various places -- if
the indicator is TRUE, then the "connect all" is assumed to have been
performed, and Intel BDS doesn't do it itself.

OVMF should pass TRUE as "ConnectAllHappened", because a few lines before
our call to PlatformBdsEnterFrontPage(), we already connect everything
with BdsLibConnectAll(), which includes the effects of
BdsLibConnectAllDriversToAllControllers():

PlatformBdsPolicyBehavior()                   [OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c]
  BdsLibConnectAll()                          [IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConnect.c]
    BdsLibConnectAllDriversToAllControllers()
  PlatformBdsEnterFrontPage()                 [IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c]

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16308 6f19259b-4bc3-4df7-8a09-765794883524

OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c

index f2ece66..9fa48c9 100644 (file)
@@ -1193,7 +1193,7 @@ Returns:
     //\r
     // Enter Setup if user input\r
     //\r
-    PlatformBdsEnterFrontPage (Timeout, FALSE);\r
+    PlatformBdsEnterFrontPage (Timeout, TRUE);\r
   }\r
 }\r
 \r