move both GetPcdMaxSize and GetPcdSize to the PcdClassObject.
fix MAX_SIZE_TYPE to have int values
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
% (RealTokenCName, RealTokenCName, RealTokenCName, RealTokenCName))\r
TokenCNameList.add(TokenCName)\r
\r
-def GetPcdSize(Pcd):\r
- if Pcd.DatumType not in TAB_PCD_NUMERIC_TYPES:\r
- Value = Pcd.DefaultValue\r
- if not Value:\r
- return 1\r
- elif Value[0] == 'L':\r
- return (len(Value) - 2) * 2\r
- elif Value[0] == '{':\r
- return len(Value.split(','))\r
- else:\r
- return len(Value) - 1\r
- if Pcd.DatumType == TAB_UINT64:\r
- return 8\r
- if Pcd.DatumType == TAB_UINT32:\r
- return 4\r
- if Pcd.DatumType == TAB_UINT16:\r
- return 2\r
- if Pcd.DatumType == TAB_UINT8:\r
- return 1\r
- if Pcd.DatumType == 'BOOLEAN':\r
- return 1\r
- else:\r
- return Pcd.MaxDatumSize\r
-\r
-\r
## Create code for module PCDs\r
#\r
# @param Info The ModuleAutoGen object\r
"The maximum size of VOID* type PCD '%s.%s' is less than its actual size occupied." % (Pcd.TokenSpaceGuidCName, TokenCName),\r
ExtraData="[%s]" % str(Info))\r
else:\r
- ArraySize = GetPcdSize(Pcd)\r
+ ArraySize = Pcd.GetPcdSize()\r
if Unicode:\r
ArraySize = ArraySize / 2\r
Value = NewValue + '0 }'\r
AutoGenH.Append('extern %s UINT8 %s%s;\n' %(Const, PcdVariableName, Array))\r
AutoGenH.Append('#define %s %s%s\n' %(GetModeName, Type, PcdVariableName))\r
\r
- PcdDataSize = GetPcdSize(Pcd)\r
+ PcdDataSize = Pcd.GetPcdSize()\r
if Pcd.Type == TAB_PCDS_FIXED_AT_BUILD:\r
AutoGenH.Append('#define %s %s\n' % (FixPcdSizeTokenName, PcdDataSize))\r
AutoGenH.Append('#define %s %s \n' % (GetModeSizeName,FixPcdSizeTokenName))\r
AutoGenH.Append('extern volatile %s %s %s%s;\n' % (Const, Pcd.DatumType, PcdVariableName, Array))\r
AutoGenH.Append('#define %s %s%s\n' % (GetModeName, Type, PcdVariableName))\r
\r
- PcdDataSize = GetPcdSize(Pcd)\r
+ PcdDataSize = Pcd.GetPcdSize()\r
AutoGenH.Append('#define %s %s\n' % (PatchPcdSizeTokenName, PcdDataSize))\r
\r
AutoGenH.Append('#define %s %s \n' % (GetModeSizeName,PatchPcdSizeVariableName))\r
AutoGenH.Append('extern UINTN %s; \n' % PatchPcdSizeVariableName)\r
AutoGenC.Append('GLOBAL_REMOVE_IF_UNREFERENCED UINTN %s = %s;\n' % (PatchPcdSizeVariableName,PcdDataSize))\r
else:\r
- PcdDataSize = GetPcdSize(Pcd)\r
+ PcdDataSize = Pcd.GetPcdSize()\r
AutoGenH.Append('#define %s %s\n' % (FixPcdSizeTokenName, PcdDataSize))\r
AutoGenH.Append('#define %s %s \n' % (GetModeSizeName,FixPcdSizeTokenName))\r
\r
else:\r
AutoGenH.Append('extern volatile %s %s%s;\n' % (DatumType, PcdVariableName, Array))\r
AutoGenH.Append('#define %s %s_gPcd_BinaryPatch_%s\n' %(GetModeName, Type, TokenCName))\r
- PcdDataSize = GetPcdSize(Pcd)\r
+ PcdDataSize = Pcd.GetPcdSize()\r
if Pcd.DatumType not in TAB_PCD_NUMERIC_TYPES:\r
AutoGenH.Append('#define %s(SizeOfBuffer, Buffer) LibPatchPcdSetPtrAndSize((VOID *)_gPcd_BinaryPatch_%s, &%s, %s, (SizeOfBuffer), (Buffer))\n' % (SetModeName, TokenCName, PatchPcdSizeVariableName, PatchPcdMaxSizeVariable))\r
AutoGenH.Append('#define %s(SizeOfBuffer, Buffer) LibPatchPcdSetPtrAndSizeS((VOID *)_gPcd_BinaryPatch_%s, &%s, %s, (SizeOfBuffer), (Buffer))\n' % (SetModeStatusName, TokenCName, PatchPcdSizeVariableName, PatchPcdMaxSizeVariable))\r
AutoGenH.Append('#define _PCD_VALUE_%s %s%s\n' %(TokenCName, Type, PcdVariableName))\r
else:\r
AutoGenH.Append('#define _PCD_VALUE_%s %s\n' %(TokenCName, Pcd.DefaultValue))\r
- PcdDataSize = GetPcdSize(Pcd)\r
+ PcdDataSize = Pcd.GetPcdSize()\r
if PcdItemType == TAB_PCDS_FIXED_AT_BUILD:\r
if Pcd.DatumType not in TAB_PCD_NUMERIC_TYPES:\r
if ConstFixedPcd:\r
\r
def updateStorageWidth(self):\r
try:\r
- self.StorageWidth = int(MAX_SIZE_TYPE[self.PcdDataType])\r
+ self.StorageWidth = MAX_SIZE_TYPE[self.PcdDataType]\r
except:\r
self.StorageWidth = 0\r
self.ValidData = False\r
## The mapping dictionary from datum type to its maximum number.\r
MAX_VAL_TYPE = {"BOOLEAN":0x01, TAB_UINT8:0xFF, TAB_UINT16:0xFFFF, TAB_UINT32:0xFFFFFFFF, TAB_UINT64:0xFFFFFFFFFFFFFFFF}\r
## The mapping dictionary from datum type to size string.\r
-MAX_SIZE_TYPE = {"BOOLEAN":"1", TAB_UINT8:"1", TAB_UINT16:"2", TAB_UINT32:"4", TAB_UINT64:"8"}\r
+MAX_SIZE_TYPE = {"BOOLEAN":1, TAB_UINT8:1, TAB_UINT16:2, TAB_UINT32:4, TAB_UINT64:8}\r
\r
TAB_DEPEX = 'Depex'\r
TAB_DEPEX_COMMON = TAB_DEPEX + TAB_SPLIT + TAB_ARCH_COMMON\r
EdkLogger.error("VpdInfoFile", BuildToolError.PARAMETER_INVALID, \r
"Invalid max datum size for VPD PCD %s.%s" % (Vpd.TokenSpaceGuidCName, Vpd.TokenCName))\r
elif Vpd.DatumType in TAB_PCD_NUMERIC_TYPES: \r
- if Vpd.MaxDatumSize is None or Vpd.MaxDatumSize == "":\r
+ if not Vpd.MaxDatumSize:\r
Vpd.MaxDatumSize = MAX_SIZE_TYPE[Vpd.DatumType]\r
else:\r
if Vpd.MaxDatumSize <= 0:\r
self.PcdValueFromComm = ""\r
self.DefinitionPosition = ("","")\r
\r
+ ## Get the maximum number of bytes\r
+ def GetPcdMaxSize(self):\r
+ if self.DatumType in TAB_PCD_NUMERIC_TYPES:\r
+ return MAX_SIZE_TYPE[self.DatumType]\r
+\r
+ MaxSize = int(self.MaxDatumSize,10) if self.MaxDatumSize else 0\r
+ if self.PcdValueFromComm:\r
+ if self.PcdValueFromComm.startswith("{") and self.PcdValueFromComm.endswith("}"):\r
+ return max([len(self.PcdValueFromComm.split(",")),MaxSize])\r
+ elif self.PcdValueFromComm.startswith("\"") or self.PcdValueFromComm.startswith("\'"):\r
+ return max([len(self.PcdValueFromComm)-2+1,MaxSize])\r
+ elif self.PcdValueFromComm.startswith("L\""):\r
+ return max([2*(len(self.PcdValueFromComm)-3+1),MaxSize])\r
+ else:\r
+ return max([len(self.PcdValueFromComm),MaxSize])\r
+ return MaxSize\r
+\r
+ ## Get the number of bytes\r
+ def GetPcdSize(self):\r
+ if self.DatumType in TAB_PCD_NUMERIC_TYPES:\r
+ return MAX_SIZE_TYPE[self.DatumType]\r
+ if not self.DefaultValue:\r
+ return 1\r
+ elif self.DefaultValue[0] == 'L':\r
+ return (len(self.DefaultValue) - 2) * 2\r
+ elif self.DefaultValue[0] == '{':\r
+ return len(self.DefaultValue.split(','))\r
+ else:\r
+ return len(self.DefaultValue) - 1\r
+\r
+\r
## Convert the class to a string\r
#\r
# Convert each member of the class to string\r
Result = Result + '"'\r
return Result\r
\r
- @staticmethod\r
- def GetPcdMaxSize(Pcd):\r
- if Pcd.DatumType in TAB_PCD_NUMERIC_TYPES:\r
- return MAX_SIZE_TYPE[Pcd.DatumType]\r
-\r
- MaxSize = int(Pcd.MaxDatumSize,10) if Pcd.MaxDatumSize else 0\r
- if Pcd.PcdValueFromComm:\r
- if Pcd.PcdValueFromComm.startswith("{") and Pcd.PcdValueFromComm.endswith("}"):\r
- return max([len(Pcd.PcdValueFromComm.split(",")),MaxSize])\r
- elif Pcd.PcdValueFromComm.startswith("\"") or Pcd.PcdValueFromComm.startswith("\'"):\r
- return max([len(Pcd.PcdValueFromComm)-2+1,MaxSize])\r
- elif Pcd.PcdValueFromComm.startswith("L\""):\r
- return max([2*(len(Pcd.PcdValueFromComm)-3+1),MaxSize])\r
- else:\r
- return max([len(Pcd.PcdValueFromComm),MaxSize])\r
- return MaxSize\r
-\r
def GenerateSizeFunction(self,Pcd):\r
CApp = "// Default Value in Dec \n"\r
CApp = CApp + "void Cal_%s_%s_Size(UINT32 *Size){\n" % (Pcd.TokenSpaceGuidCName, Pcd.TokenCName)\r
while '[' in FieldName:\r
FieldName = FieldName.rsplit('[', 1)[0]\r
CApp = CApp + ' __FLEXIBLE_SIZE(*Size, %s, %s, %d); // From %s Line %d Value %s \n' % (Pcd.DatumType, FieldName.strip("."), ArrayIndex + 1, Pcd.PcdFieldValueFromComm[FieldName_ori][1], Pcd.PcdFieldValueFromComm[FieldName_ori][2], Pcd.PcdFieldValueFromComm[FieldName_ori][0])\r
- CApp = CApp + " *Size = (%d > *Size ? %d : *Size); // The Pcd maxsize is %d \n" % (DscBuildData.GetPcdMaxSize(Pcd),DscBuildData.GetPcdMaxSize(Pcd),DscBuildData.GetPcdMaxSize(Pcd))\r
+ CApp = CApp + " *Size = (%d > *Size ? %d : *Size); // The Pcd maxsize is %d \n" % (Pcd.GetPcdMaxSize(),Pcd.GetPcdMaxSize(),Pcd.GetPcdMaxSize())\r
CApp = CApp + "}\n"\r
return CApp\r
\r