ShellPkg/UefiShellDriver1CommandsLib: fix parameter list typo

The ShellCommandRunConnect() function passes EFI_HANDLE -- (VOID*) --
objects to ConvertAndConnectControllers(), and
ConvertAndConnectControllers() passes those to gBS->OpenProtocol().

Accordingly, ConvertAndConnectControllers() should specify EFI_HANDLE
parameter types, not (EFI_HANDLE*) -- (VOID**) -- types.

This typo is masked because (VOID*) converts to and from any
pointer-to-object type silently.

Note that functionally speaking there is no problem, so this patch does
not change beavior, only cleans up the code.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c b/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c
index 359394dfd291b80da13e90a36791f0110aa40fc8..3f4e132674ea7cb813b81f0d36df68b7813d3401 100644 (file)
--- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c
+++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c
@@ -346,8 +346,8 @@ ShellConnectFromDevPaths (
 **/\r
 EFI_STATUS\r
 ConvertAndConnectControllers (\r
-  IN EFI_HANDLE     *Handle1 OPTIONAL,\r
-  IN EFI_HANDLE     *Handle2 OPTIONAL,\r
+  IN EFI_HANDLE     Handle1 OPTIONAL,\r
+  IN EFI_HANDLE     Handle2 OPTIONAL,\r
   IN CONST BOOLEAN  Recursive,\r
   IN CONST BOOLEAN  Output\r
   )\r