Update DebugLib to provide support for "err" command in the EFI Shell to adjust the...

1) Add DebugMask.h that defines the GUID and Protocol used by the "err" EFI Shell command to get/set the global mask and get/set the module scoped masks
2) Add DxeDebugPrintErrorLevelLib that provide an implementation of the DebugPrintErrorLevbel library classes that uses the GUID and Protocol defined in DebugMask.h to "err" EFI Shell compatibility.
3) Add default mapping for the DebugPrintErrirLevelLib to the DSC file for this package.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11366 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/MdeModulePkg/Include/Guid/DebugMask.h b/MdeModulePkg/Include/Guid/DebugMask.h
new file mode 100644 (file)
index 0000000..cfb0a69
--- /dev/null
+++ b/MdeModulePkg/Include/Guid/DebugMask.h
@@ -0,0 +1,73 @@
+/** @file\r
+\r
+  Debug Mask Protocol.\r
+\r
+Copyright (c) 2011, Intel Corporation. All rights reserved.<BR>\r
+This program and the accompanying materials are licensed and made available under \r
+the terms and conditions of the BSD License that accompanies this distribution.  \r
+The full text of the license may be found at\r
+http://opensource.org/licenses/bsd-license.php.                                            \r
+\r
+THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,                     \r
+WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.\r
+\r
+**/\r
+\r
+#ifndef __DEBUG_MASK_H__\r
+#define __DEBUG_MASK_H__\r
+\r
+///\r
+/// Protocol GUID for DXE Phase Debug Mask support\r
+///\r
+#define EFI_DEBUG_MASK_PROTOCOL_GUID \\r
+  { 0x4c8a2451, 0xc207, 0x405b, {0x96, 0x94, 0x99, 0xea, 0x13, 0x25, 0x13, 0x41} }\r
+\r
+///\r
+/// Forward reference for pure ANSI compatability\r
+///\r
+typedef struct _EFI_DEBUG_MASK_PROTOCOL  EFI_DEBUG_MASK_PROTOCOL;\r
+\r
+///\r
+///\r
+///  \r
+#define EFI_DEBUG_MASK_REVISION        0x00010000\r
+\r
+//\r
+// DebugMask member functions definition\r
+//\r
+typedef\r
+EFI_STATUS\r
+(EFIAPI * EFI_GET_DEBUG_MASK) (\r
+  IN EFI_DEBUG_MASK_PROTOCOL  *This,             \r
+  IN OUT UINTN                *CurrentDebugMask  \r
+  );\r
+\r
+typedef \r
+EFI_STATUS\r
+(EFIAPI *EFI_SET_DEBUG_MASK) (\r
+  IN EFI_DEBUG_MASK_PROTOCOL  *This,\r
+  IN UINTN                    NewDebugMask\r
+  );\r
+\r
+///\r
+/// DebugMask protocol definition\r
+///\r
+struct _EFI_DEBUG_MASK_PROTOCOL {\r
+  INT64               Revision;\r
+  EFI_GET_DEBUG_MASK  GetDebugMask;\r
+  EFI_SET_DEBUG_MASK  SetDebugMask;\r
+};\r
+\r
+extern EFI_GUID gEfiDebugMaskProtocolGuid;\r
+\r
+///\r
+/// GUID used to store the global debug mask in an the "EFIDebug" EFI Variabe\r
+///\r
+#define EFI_GENERIC_VARIABLE_GUID \\r
+  { 0x59d1c24f, 0x50f1, 0x401a, {0xb1, 0x01, 0xf3, 0x3e, 0x0d, 0xae, 0xd4, 0x43} }\r
+  \r
+#define DEBUG_MASK_VARIABLE_NAME  L"EFIDebug"\r
+\r
+extern EFI_GUID gEfiGenericVariableGuid;\r
+\r
+#endif\r

diff --git a/MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.c b/MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.c
new file mode 100644 (file)
index 0000000..195432d
--- /dev/null
+++ b/MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.c
@@ -0,0 +1,341 @@
+/** @file\r
+  Debug Print Error Level library instance that provide compatibility with the \r
+  "err" shell command.  This includes support for the Debug Mask Protocol\r
+  supports for global debug print error level mask stored in an EFI Variable.\r
+  This library instance only support DXE Phase modules.\r
+\r
+  Copyright (c) 2011, Intel Corporation. All rights reserved.<BR>\r
+  This program and the accompanying materials\r
+  are licensed and made available under the terms and conditions of the BSD License\r
+  which accompanies this distribution.  The full text of the license may be found at\r
+  http://opensource.org/licenses/bsd-license.php.\r
+\r
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,\r
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.\r
+\r
+**/\r
+\r
+#include <PiDxe.h>\r
+\r
+#include <Library/DebugPrintErrorLevelLib.h>\r
+#include <Library/PcdLib.h>\r
+\r
+#include <Guid/DebugMask.h>\r
+\r
+///\r
+/// Debug Mask Protocol function prototypes\r
+///\r
+EFI_STATUS\r
+EFIAPI\r
+GetDebugMask (\r
+  IN EFI_DEBUG_MASK_PROTOCOL  *This,             \r
+  IN OUT UINTN                *CurrentDebugMask  \r
+  );\r
+\r
+EFI_STATUS\r
+EFIAPI\r
+SetDebugMask (\r
+  IN EFI_DEBUG_MASK_PROTOCOL  *This,\r
+  IN UINTN                    NewDebugMask\r
+  );\r
+\r
+///\r
+/// Debug Mask Protocol instance\r
+///\r
+EFI_DEBUG_MASK_PROTOCOL  mDebugMaskProtocol = {\r
+  EFI_DEBUG_MASK_REVISION,\r
+  GetDebugMask,\r
+  SetDebugMask\r
+};\r
+\r
+///\r
+/// Global variable that is set to TRUE after the first attempt is made to \r
+/// retrieve the global error level mask through the EFI Varibale Services.\r
+/// This variable prevents the EFI Variable Services from being called fort\r
+/// every DEBUG() macro.\r
+///\r
+BOOLEAN           mGlobalErrorLevelInitialized = FALSE;\r
+\r
+///\r
+/// Global variable that contains the current debug error level mask for the\r
+/// module that is using this library instance.  This variable is initially\r
+/// set to the PcdDebugPrintErrorLevel value.  If the EFI Variable exists that\r
+/// contains the global debug print error level mask, then that override the\r
+/// PcdDebugPrintErrorLevel value.  If the Debug Mask Protocol SetDebugMask()\r
+/// service is called, then that overrides bit the PcdDebugPrintErrorLevel and\r
+/// the EFI Variable setting.\r
+///\r
+UINT32            mDebugPrintErrorLevel        = 0;\r
+\r
+///\r
+/// Global variable that is used to cache a pointer to the EFI System Table\r
+/// that is required to access the EFI Variable Services to get and set\r
+/// the global debug print error level mask value.  The UefiBootServicesTableLib\r
+/// is not used to prevent a circular dependency between these libraries.\r
+///\r
+EFI_SYSTEM_TABLE  *mST                         = NULL;\r
+\r
+/**\r
+  The constructor function caches the PCI Express Base Address and creates a \r
+  Set Virtual Address Map event to convert physical address to virtual addresses.\r
+  \r
+  @param  ImageHandle   The firmware allocated handle for the EFI image.\r
+  @param  SystemTable   A pointer to the EFI System Table.\r
+  \r
+  @retval EFI_SUCCESS   The constructor completed successfully.\r
+  @retval Other value   The constructor did not complete successfully.\r
+\r
+**/\r
+EFI_STATUS\r
+EFIAPI\r
+DxeDebugPrintErrorLevelLibConstructor (\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
+  )\r
+{\r
+  EFI_STATUS  Status;\r
+\r
+  //\r
+  // Initialize the error level mask from PCD setting.\r
+  //\r
+  mDebugPrintErrorLevel = PcdGet32 (PcdDebugPrintErrorLevel);\r
+  \r
+  //\r
+  // Install Debug Mask Protocol onto ImageHandle\r
+  //  \r
+  mST = SystemTable;\r
+  Status = SystemTable->BootServices->InstallMultipleProtocolInterfaces (\r
+                                        &ImageHandle,\r
+                                        &gEfiDebugMaskProtocolGuid, &mDebugMaskProtocol,\r
+                                        NULL\r
+                                        );\r
+\r
+  //\r
+  // Attempt to retrieve the global debug print error level mask from the EFI Variable\r
+  // If the EFI Variable can not be accessed when this module's library constructors are\r
+  // executed, then the EFI Variable access will be reattempted on every DEBUG() print\r
+  // from this module until the EFI Variable services are available.\r
+  //\r
+  GetDebugPrintErrorLevel ();\r
+  \r
+  return Status;\r
+}\r
+\r
+/**\r
+  The destructor function frees any allocated buffers and closes the Set Virtual \r
+  Address Map event.\r
+  \r
+  @param  ImageHandle   The firmware allocated handle for the EFI image.\r
+  @param  SystemTable   A pointer to the EFI System Table.\r
+  \r
+  @retval EFI_SUCCESS   The destructor completed successfully.\r
+  @retval Other value   The destructor did not complete successfully.\r
+\r
+**/\r
+EFI_STATUS\r
+EFIAPI\r
+DxeDebugPrintErrorLevelLibDestructor (\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
+  )\r
+{\r
+  //\r
+  // Uninstall the Debug Mask Protocol from ImageHandle\r
+  //  \r
+  return SystemTable->BootServices->UninstallMultipleProtocolInterfaces (\r
+                                      ImageHandle,\r
+                                      &gEfiDebugMaskProtocolGuid, &mDebugMaskProtocol,\r
+                                      NULL\r
+                                      );\r
+}\r
+\r
+/**\r
+  Returns the debug print error level mask for the current module.\r
+\r
+  @return  Debug print error level mask for the current module.\r
+\r
+**/\r
+UINT32\r
+EFIAPI\r
+GetDebugPrintErrorLevel (\r
+  VOID\r
+  )\r
+{\r
+  EFI_STATUS  Status;\r
+  EFI_TPL     CurrentTpl;\r
+  UINTN       Size;\r
+  UINTN       GlobalErrorLevel;\r
+\r
+  //\r
+  // If the constructor has not been executed yet, then just return the PCD value.\r
+  // This case should only occur if debug print is generated by a library\r
+  // constructor for this module\r
+  //\r
+  if (mST == NULL) {\r
+    return PcdGet32 (PcdDebugPrintErrorLevel);\r
+  }\r
+\r
+  //\r
+  // Check to see if an attempt has been mde to retrieve the global debug print \r
+  // error level mask.  Since this libtrary instance stores the global debug print\r
+  // error level mask in an EFI Variable, the EFI Variable should only be accessed\r
+  // once to reduce the overhead of reading the EFI Variable on every debug print\r
+  //  \r
+  if (!mGlobalErrorLevelInitialized) {\r
+    //\r
+    // Make sure the TPL Level is low enough for EFI Variable Services to be called\r
+    //\r
+    CurrentTpl = mST->BootServices->RaiseTPL (TPL_HIGH_LEVEL);\r
+    mST->BootServices->RestoreTPL (CurrentTpl);\r
+    if (CurrentTpl <= TPL_CALLBACK) {\r
+      //\r
+      // Attempt to retrieve the global debug print error level mask from the \r
+      // EFI Variable\r
+      //\r
+      Size = sizeof (GlobalErrorLevel);\r
+      Status = mST->RuntimeServices->GetVariable (\r
+                                       DEBUG_MASK_VARIABLE_NAME, \r
+                                       &gEfiGenericVariableGuid, \r
+                                       NULL, \r
+                                       &Size, \r
+                                       &GlobalErrorLevel\r
+                                       );\r
+      if (Status != EFI_NOT_AVAILABLE_YET) {\r
+        //\r
+        // If EFI Variable Services are available, then set a flag so the EFI\r
+        // Variable will not be read again by this module.\r
+        //\r
+        mGlobalErrorLevelInitialized = TRUE;\r
+        if (!EFI_ERROR (Status)) {\r
+          //\r
+          // If the EFI Varible exists, then set this module's module's mask to\r
+          // the global debug print error level mask value.\r
+          //\r
+          mDebugPrintErrorLevel = (UINT32)GlobalErrorLevel;\r
+        }\r
+      }\r
+    }\r
+  }\r
+\r
+  //\r
+  // Return the current mask value for this module.\r
+  //\r
+  return mDebugPrintErrorLevel;\r
+}\r
+\r
+/**\r
+  Sets the global debug print error level mask fpr the entire platform.\r
+\r
+  @retval  TRUE   The debug print error level mask was sucessfully set.\r
+  @retval  FALSE  The debug print error level mask could not be set.\r
+\r
+**/\r
+BOOLEAN\r
+EFIAPI\r
+SetDebugPrintErrorLevel (\r
+  UINT32  ErrorLevel\r
+  )\r
+{\r
+  EFI_STATUS  Status;\r
+  EFI_TPL     CurrentTpl;\r
+  UINTN       Size;\r
+  UINTN       GlobalErrorLevel;\r
+\r
+  //\r
+  // Make sure the constructor has been executed\r
+  //\r
+  if (mST != NULL) {\r
+    //\r
+    // Make sure the TPL Level is low enough for EFI Variable Services\r
+    //\r
+    CurrentTpl = mST->BootServices->RaiseTPL (TPL_HIGH_LEVEL);\r
+    mST->BootServices->RestoreTPL (CurrentTpl);\r
+    if (CurrentTpl <= TPL_CALLBACK) {\r
+      //\r
+      // Attempt to store the global debug print error level mask in an EFI Variable\r
+      //\r
+      GlobalErrorLevel = (UINTN)ErrorLevel;\r
+      Size = sizeof (GlobalErrorLevel);\r
+      Status = mST->RuntimeServices->SetVariable (\r
+                                       DEBUG_MASK_VARIABLE_NAME, \r
+                                       &gEfiGenericVariableGuid, \r
+                                       (EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS),\r
+                                       Size,\r
+                                       &GlobalErrorLevel\r
+                                       );\r
+      if (!EFI_ERROR (Status)) {\r
+        //\r
+        // If the EFI Variable was updated, then update the mask value for this \r
+        // module and return TRUE.\r
+        //\r
+        mGlobalErrorLevelInitialized = TRUE;    \r
+        mDebugPrintErrorLevel = ErrorLevel;\r
+        return TRUE;\r
+      }\r
+    }\r
+  }\r
+  //\r
+  // Return FALSE since the EFI Variable could not be updated.\r
+  //\r
+  return FALSE;\r
+}\r
+\r
+/**\r
+  Retrieves the current debug print error level mask for a module are returns\r
+  it in CurrentDebugMask.\r
+\r
+  @param  This              The protocol instance pointer.\r
+  @param  CurrentDebugMask  Pointer to the debug print error level mask that \r
+                            is returned.\r
+\r
+  @retval EFI_SUCCESS            The current debug print error level mask was\r
+                                 returned in CurrentDebugMask.\r
+  @retval EFI_INVALID_PARAMETER  CurrentDebugMask is NULL.\r
+  @retval EFI_DEVICE_ERROR       The current debug print error level mask could\r
+                                 not be retrieved.\r
+\r
+**/\r
+EFI_STATUS\r
+EFIAPI\r
+GetDebugMask (\r
+  IN EFI_DEBUG_MASK_PROTOCOL  *This,             \r
+  IN OUT UINTN                *CurrentDebugMask  \r
+  )\r
+{\r
+  if (CurrentDebugMask == NULL) {\r
+    return EFI_INVALID_PARAMETER;\r
+  }\r
+  \r
+  //\r
+  // Retrieve the current debug mask from mDebugPrintErrorLevel\r
+  //\r
+  *CurrentDebugMask = (UINTN)mDebugPrintErrorLevel;\r
+  return EFI_SUCCESS;\r
+}\r
+\r
+/**\r
+  Sets the current debug print error level mask for a module to the value\r
+  specified by NewDebugMask.\r
+\r
+  @param  This          The protocol instance pointer.\r
+  @param  NewDebugMask  The new debug print error level mask for this module.\r
+\r
+  @retval EFI_SUCCESS            The current debug print error level mask was\r
+                                 set to the value specified by NewDebugMask.\r
+  @retval EFI_DEVICE_ERROR       The current debug print error level mask could\r
+                                 not be set to the value specified by NewDebugMask.\r
+\r
+**/\r
+EFI_STATUS\r
+EFIAPI\r
+SetDebugMask (\r
+  IN EFI_DEBUG_MASK_PROTOCOL  *This,\r
+  IN UINTN                    NewDebugMask\r
+  )\r
+{\r
+  //\r
+  // Store the new debug mask into mDebugPrintErrorLevel\r
+  //\r
+  mDebugPrintErrorLevel = (UINT32)NewDebugMask;\r
+  return EFI_SUCCESS;\r
+}\r

diff --git a/MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf b/MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf
new file mode 100644 (file)
index 0000000..a4a44b1
--- /dev/null
+++ b/MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf
@@ -0,0 +1,50 @@
+## @file\r
+#  Debug Print Error Level library instance that provide compatibility with the \r
+#  "err" shell command.  This includes support for the Debug Mask Protocol\r
+#  supports for global debug print error level mask stored in an EFI Variable.\r
+#  This library instance only support DXE Phase modules.\r
+#\r
+#  Copyright (c) 2011, Intel Corporation. All rights reserved.<BR>\r
+#\r
+#  This program and the accompanying materials\r
+#  are licensed and made available under the terms and conditions of the BSD License\r
+#  which accompanies this distribution. The full text of the license may be found at\r
+#  http://opensource.org/licenses/bsd-license.php.\r
+#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,\r
+#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.\r
+#\r
+#\r
+##\r
+\r
+[Defines]\r
+  INF_VERSION                    = 0x00010005\r
+  BASE_NAME                      = DxeDebugPrintErrorLevelLib\r
+  FILE_GUID                      = 1D564EC9-9373-49a4-9E3F-E4D7B9974C84\r
+  MODULE_TYPE                    = DXE_DRIVER\r
+  VERSION_STRING                 = 1.0\r
+  LIBRARY_CLASS                  = DebugPrintErrorLevelLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER UEFI_APPLICATION UEFI_DRIVER \r
+  CONSTRUCTOR                    = DxeDebugPrintErrorLevelLibConstructor\r
+  DESTRUCTOR                     = DxeDebugPrintErrorLevelLibDestructor\r
+\r
+#\r
+#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC\r
+#\r
+\r
+[Sources]\r
+  DxeDebugPrintErrorLevelLib.c\r
+\r
+[Packages]\r
+  MdePkg/MdePkg.dec\r
+  MdeModulePkg/MdeModulePkg.dec\r
+\r
+[LibraryClasses]\r
+  PcdLib\r
+  \r
+[Protocols]\r
+  gEfiDebugMaskProtocolGuid\r
+  \r
+[Guids]\r
+  gEfiGenericVariableGuid  \r
+\r
+[Pcd]\r
+  gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel\r

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 045fd4152a7f5c91605917a0312c7ac6957d943a..ae0836a223a370b55fd57f2f15bb46bf324a409b 100644 (file)
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -162,6 +162,10 @@
   #  Include/Guid/LoadModuleAtFixedAddress.h\r
   gLoadFixedAddressConfigurationTableGuid  = { 0x2CA88B53,0xD296,0x4080, { 0xA4,0xA5,0xCA,0xD9,0xBA,0xE2,0x4B,0x9 } }\r
 \r
+  ## GUID used to store the global debug mask value into an EFI Variable\r
+  # Include/Guid/DebugMask.h  \r
+  gEfiGenericVariableGuid = { 0x59d1c24f, 0x50f1, 0x401a, {0xb1, 0x01, 0xf3, 0x3e, 0x0d, 0xae, 0xd4, 0x43} }\r
+  \r
 [Protocols]\r
   ## Load File protocol provides capability to load and unload EFI image into memory and execute it.\r
   #  Include/Protocol/LoadPe32Image.h\r
@@ -204,6 +208,9 @@
   #  Include/Protocol/SmmFirmwareVolumeBlock.h\r
   gEfiSmmFirmwareVolumeBlockProtocolGuid = { 0xd326d041, 0xbd31, 0x4c01, { 0xb5, 0xa8, 0x62, 0x8b, 0xe8, 0x7f, 0x6, 0x53 }}\r
 \r
+  ## This protocol allows the error level mask for DEBUG() macros to be adjusted for DXE Phase modules\r
+  # Include/Guid/DebugMask.h  \r
+  gEfiDebugMaskProtocolGuid = { 0x4c8a2451, 0xc207, 0x405b, {0x96, 0x94, 0x99, 0xea, 0x13, 0x25, 0x13, 0x41} }\r
 [PcdsFeatureFlag]\r
   ## Indicate whether platform can support update capsule across a system reset\r
   gEfiMdeModulePkgTokenSpaceGuid.PcdSupportUpdateCapsuleReset|FALSE|BOOLEAN|0x0001001d\r

diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
index 89cf09e2c5b2fe688b3885638494a4150c8fd583..820b0b7ba23b4a0278cd076a0cfc97de2d1541ca 100644 (file)
--- a/MdeModulePkg/MdeModulePkg.dsc
+++ b/MdeModulePkg/MdeModulePkg.dsc
@@ -80,6 +80,7 @@
   # Misc\r
   #\r
   DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf\r
+  DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf  \r
   ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf  \r
   PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf\r
   PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf\r
@@ -132,13 +133,13 @@
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf\r
   DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf\r
 \r
-[LibraryClasses.ARM]
-  #
-  # It is not possible to prevent the ARM compiler for generic intrinsic functions.
-  # This library provides the instrinsic functions generate by a given compiler.
-  # [LibraryClasses.ARM] and NULL mean link this library into all ARM images.
-  #
-  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
+[LibraryClasses.ARM]\r
+  #\r
+  # It is not possible to prevent the ARM compiler for generic intrinsic functions.\r
+  # This library provides the instrinsic functions generate by a given compiler.\r
+  # [LibraryClasses.ARM] and NULL mean link this library into all ARM images.\r
+  #\r
+  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf\r
 \r
 \r
 [PcdsFeatureFlag]\r