]> git.proxmox.com Git - mirror_edk2.git/commitdiff
ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser
authorAshish Singhal <ashishsingha@nvidia.com>
Mon, 20 Jan 2020 05:44:34 +0000 (13:44 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Tue, 11 Feb 2020 02:12:45 +0000 (02:12 +0000)
FADT parser was checking for reduced ACPI flag incorrectly
leading to incorrect error message if FIRMWARE_CTRL and
X_FIRMWARE_CTRL are both 0.

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c

index 5b8cc174f16afb3d4feb6a518952e60c6564ee34..8acfbac3b1d4a0071cf2481a6852bf6c2d95e91a 100644 (file)
@@ -253,7 +253,7 @@ ParseAcpiFadt (
     // present.\r
     if ((Trace) &&\r
         (Flags != NULL) &&\r
-        ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) != 0)) {\r
+        ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) != EFI_ACPI_6_3_HW_REDUCED_ACPI)) {\r
       IncrementErrorCount ();\r
       Print (L"ERROR: No FACS table found, "\r
                L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are zero.\n");\r