ShellPkg: acpiview: Remove '-v' flag from allowed command line args

According to the acpiview documentation, the -v flag enables verbose
output and it is set on default.

Moreover, the acpiview UEFI shell tool dumps the same output with
and without this flag set.

Therefore this patch removes the superfluous -v flag from allowed
command line parameters.

Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
index e99537acf36616783103e1e9d154278f8dedb78e..911b2da3dd9f19010d0f4993bcf017749cafb749 100644 (file)
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
@@ -25,7 +25,6 @@ STATIC BOOLEAN            mSelectedAcpiTableFound;
 STATIC EREPORT_OPTION     mReportType;\r
 STATIC UINT32             mTableCount;\r
 STATIC UINT32             mBinTableCount;\r
-STATIC BOOLEAN            mVerbose;\r
 STATIC BOOLEAN            mConsistencyCheck;\r
 STATIC BOOLEAN            mColourHighlighting;\r
 \r
@@ -38,7 +37,6 @@ STATIC CONST SHELL_PARAM_ITEM ParamList[] = {
   {L"-h", TypeValue},\r
   {L"-l", TypeFlag},\r
   {L"-s", TypeValue},\r
-  {L"-v", TypeFlag},\r
   {NULL, TypeMax}\r
 };\r
 \r
@@ -472,7 +470,6 @@ ShellCommandRunAcpiView (
   mSelectedAcpiTable = 0;\r
   mSelectedAcpiTableName = NULL;\r
   mSelectedAcpiTableFound = FALSE;\r
-  mVerbose = TRUE;\r
   mConsistencyCheck = TRUE;\r
 \r
   ShellStatus = SHELL_SUCCESS;\r

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
index f0610870505d5c5d89e6516122fc9e782479df0c..0d10b5debe470cb096cf414d0a0144fd3bde03ee 100644 (file)
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
@@ -30,7 +30,7 @@
 "Display ACPI Table information.\r\n"\r
 ".SH SYNOPSIS\r\n"\r
 " \r\n"\r
-"ACPIVIEW [[-?] | [[-l] | [-s AcpiTable [-d]]] [-q] [-v] [-h Highlight]]\r\n"\r
+"ACPIVIEW [[-?] | [[-l] | [-s AcpiTable [-d]]] [-q] [-h Highlight]]\r\n"\r
 " \r\n"\r
 ".SH OPTIONS\r\n"\r
 " \r\n"\r
@@ -40,7 +40,6 @@
 "         AcpiTable    : The required ACPI Table type.\r\n"\r
 "  -d - Generate a binary file dump of the specified AcpiTable.\r\n"\r
 "  -q - Quiet. Suppress errors and warnings. Disables consistency checks.\r\n"\r
-"  -v - Display verbose data (enabled by default).\r\n"\r
 "  -h - Enable/Disable Colour Highlighting.\r\n"\r
 "         Highlight    : TRUE/ON enables highlighting;\r\n"\r
 "                        FALSE/OFF (default) disables highlighting.\r\n"\r