Fix the IN OUT modifier for parameters.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7147 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/ComponentName.c b/MdeModulePkg/Universal/Network/Tcp4Dxe/ComponentName.c
index 377fd3bb4bae05ce0c95c3c4b9fd25b1927cd671..85afc525e83813ba1ca41db24eb4f198e1fb1e0e 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/ComponentName.c
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/ComponentName.c
@@ -222,7 +222,7 @@ TcpComponentNameGetDriverName (
            This->SupportedLanguages,\r
            mTcpDriverNameTable,\r
            DriverName,\r
-           (BOOLEAN)(This == &gTcp4ComponentName)\r
+           (BOOLEAN) (This == &gTcp4ComponentName)\r
            );\r
 }\r
 \r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c b/MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c
index 1e27bfbf97ce9800faada45497a816072000e313..b8a8258bedeb2711ba19f9824da32562d3670e72 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c
@@ -41,7 +41,7 @@ SockTcpDataToRcv (
 **/\r
 VOID\r
 SockProcessSndToken (\r
-  IN SOCKET *Sock\r
+  IN OUT SOCKET *Sock\r
   );\r
 \r
 /**\r
@@ -148,7 +148,7 @@ SockTcpDataToRcv (
   @param  Sock                  Pointer to the socket.\r
   @param  TcpRxData             Pointer to the application provided receive buffer.\r
   @param  RcvdBytes             The maximum length of the data can be copied.\r
-  @param  IsOOB                 If TURE the data is OOB, else the data is normal.\r
+  @param  IsOOB                 If TURE the data is OOB, FALSE the data is normal.\r
 \r
 **/\r
 VOID\r
@@ -204,8 +204,8 @@ SockSetTcpRxData (
 **/\r
 UINT32\r
 SockProcessRcvToken (\r
-  IN SOCKET        *Sock,\r
-  IN SOCK_IO_TOKEN *RcvToken\r
+  IN     SOCKET        *Sock,\r
+  IN OUT SOCK_IO_TOKEN *RcvToken\r
   )\r
 {\r
   UINT32                 TokenRcvdBytes;\r
@@ -242,7 +242,7 @@ SockProcessRcvToken (
   the buffer to socket send buffer,then try to send it.\r
 \r
   @param  Sock                  Pointer to the socket.\r
-  @param  TcpTxData             Pointer to the tcp txdata.\r
+  @param  TcpTxData             Pointer to the application provided send buffer.\r
 \r
   @retval EFI_SUCCESS           The operation is completed successfully.\r
   @retval EFI_OUT_OF_RESOURCES  Failed due to resource limit.\r
@@ -358,7 +358,7 @@ SockFlushPendingToken (
 **/\r
 VOID\r
 SockWakeConnToken (\r
-  IN SOCKET *Sock\r
+  IN OUT SOCKET *Sock\r
   )\r
 {\r
   ASSERT (Sock->ConnectionToken != NULL);\r
@@ -382,7 +382,7 @@ SockWakeConnToken (
 **/\r
 VOID\r
 SockWakeListenToken (\r
-  IN SOCKET *Sock\r
+  IN OUT SOCKET *Sock\r
   )\r
 {\r
   SOCKET                *Parent;\r
@@ -470,7 +470,7 @@ SockWakeRcvToken (
 **/\r
 VOID\r
 SockProcessSndToken (\r
-  IN SOCKET *Sock\r
+  IN OUT SOCKET *Sock\r
   )\r
 {\r
   UINT32                  FreeSpace;\r
@@ -712,7 +712,7 @@ OnError:
 **/\r
 VOID\r
 SockDestroy (\r
-  IN SOCKET *Sock\r
+  IN OUT SOCKET *Sock\r
   )\r
 {\r
   VOID        *SockProtocol;\r
@@ -804,14 +804,14 @@ FreeSock:
 \r
 \r
 /**\r
-  Flush the socket.\r
+  Flush the sndBuffer and rcvBuffer of socket.\r
 \r
   @param  Sock                  Pointer to the socket.\r
 \r
 **/\r
 VOID\r
 SockConnFlush (\r
-  IN SOCKET *Sock\r
+  IN OUT SOCKET *Sock\r
   )\r
 {\r
   SOCKET  *Child;\r
@@ -877,8 +877,8 @@ SockConnFlush (
 **/\r
 VOID\r
 SockSetState (\r
-  IN SOCKET     *Sock,\r
-  IN SOCK_STATE State\r
+  IN OUT SOCKET     *Sock,\r
+  IN     SOCK_STATE State\r
   )\r
 {\r
   Sock->State = State;\r
@@ -972,7 +972,7 @@ SockConnEstablished (
 **/\r
 VOID\r
 SockConnClosed (\r
-  IN SOCKET *Sock\r
+  IN OUT SOCKET *Sock\r
   )\r
 {\r
   if (Sock->CloseToken != NULL) {\r
@@ -1094,9 +1094,9 @@ SockGetDataToSend (
 **/\r
 VOID\r
 SockDataRcvd (\r
-  IN SOCKET    *Sock,\r
-  IN NET_BUF   *NetBuffer,\r
-  IN UINT32    UrgLen\r
+  IN     SOCKET    *Sock,\r
+  IN OUT NET_BUF   *NetBuffer,\r
+  IN     UINT32    UrgLen\r
   )\r
 {\r
   ASSERT ((Sock != NULL) && (Sock->RcvBuffer.DataQueue != NULL) &&\r
@@ -1161,8 +1161,8 @@ SockGetFreeSpace (
 **/\r
 VOID\r
 SockRcvdErr (\r
-  IN SOCKET       *Sock,\r
-  IN EFI_STATUS   Error\r
+  IN OUT SOCKET       *Sock,\r
+  IN     EFI_STATUS   Error\r
   )\r
 {\r
   SOCK_TOKEN  *SockToken;\r
@@ -1199,7 +1199,7 @@ SockRcvdErr (
 **/\r
 VOID\r
 SockNoMoreData (\r
-  IN SOCKET *Sock\r
+  IN OUT SOCKET *Sock\r
   )\r
 {\r
   EFI_STATUS  Err;\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.h b/MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.h
index 7381f4460e6d59894e4164408cfeadb44323a961..840f6b16934fe0acca5a6376b311d300b79e7bcf 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.h
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.h
@@ -86,8 +86,8 @@ SockSetTcpRxData (
 **/\r
 UINT32\r
 SockProcessRcvToken (\r
-  IN SOCKET        *Sock,\r
-  IN SOCK_IO_TOKEN *RcvToken\r
+  IN     SOCKET        *Sock,\r
+  IN OUT SOCK_IO_TOKEN *RcvToken\r
   );\r
 \r
 /**\r
@@ -98,7 +98,7 @@ SockProcessRcvToken (
 **/\r
 VOID\r
 SockConnFlush (\r
-  IN SOCKET *Sock\r
+  IN OUT SOCKET *Sock\r
   );\r
 \r
 /**\r
@@ -122,7 +122,7 @@ SockCreate (
 **/\r
 VOID\r
 SockDestroy (\r
-  IN SOCKET *Sock\r
+  IN OUT SOCKET *Sock\r
   );\r
 \r
 #endif\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/SockInterface.c b/MdeModulePkg/Universal/Network/Tcp4Dxe/SockInterface.c
index c0756954674acf868ce13c48243ff237a9866827..f7b0e99c39945a5e19a5e68ae32de0a980119b85 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/SockInterface.c
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/SockInterface.c
@@ -22,7 +22,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
   @param  Event                The event to be checked.\r
 \r
   @retval  TRUE                The specific Event exists in the List. \r
-  @retval  False               The specific Event is not in the List.\r
+  @retval  FALSE               The specific Event is not in the List.\r
 \r
 **/\r
 BOOLEAN\r
@@ -57,7 +57,8 @@ SockTokenExistedInList (
   @param  Sock                 Pointer to the instance's socket.\r
   @param  Event                The event to be checked.\r
 \r
-  @return The specific Event exists in one of socket's lists or not.\r
+  @retval  TRUE                The Event exists in related socket's lists. \r
+  @retval  FALSE               The Event is not in related socket's lists.\r
 \r
 **/\r
 BOOLEAN\r
@@ -139,7 +140,7 @@ SockBufferToken (
 **/\r
 EFI_STATUS\r
 SockDestroyChild (\r
-  IN   SOCKET *Sock\r
+  IN SOCKET *Sock\r
   )\r
 {\r
   EFI_STATUS  Status;\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h b/MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h
index 8d917b13eaa9d4bef252428ffc5715db25b72695..0992a2c15b1f5289d7db8d6d0d3358178c2f6e6a 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h
@@ -14,7 +14,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #ifndef _SOCKET_H_\r
 #define _SOCKET_H_\r
 \r
-#include <PiDxe.h>\r
+#include <Uefi.h>\r
 \r
 #include <Protocol/Ip4.h>\r
 #include <Protocol/Tcp4.h>\r
@@ -23,12 +23,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/NetLib.h>\r
 #include <Library/DebugLib.h>\r
 #include <Library/UefiRuntimeServicesTableLib.h>\r
-#include <Library/UefiDriverEntryPoint.h>\r
 #include <Library/UefiBootServicesTableLib.h>\r
-#include <Library/BaseLib.h>\r
 #include <Library/UefiLib.h>\r
-#include <Library/MemoryAllocationLib.h>\r
-#include <Library/BaseMemoryLib.h>\r
 \r
 #define SOCK_SND_BUF        0\r
 #define SOCK_RCV_BUF        1\r
@@ -244,8 +240,8 @@ EFI_STATUS
 **/\r
 VOID\r
 SockSetState (\r
-  IN SOCKET     *Sock,\r
-  IN SOCK_STATE State\r
+  IN OUT SOCKET     *Sock,\r
+  IN     SOCK_STATE State\r
   );\r
 \r
 /**\r
@@ -276,7 +272,7 @@ SockConnEstablished (
 **/\r
 VOID\r
 SockConnClosed (\r
-  IN SOCKET *Sock\r
+  IN OUT SOCKET *Sock\r
   );\r
 \r
 /**\r
@@ -328,7 +324,7 @@ SockGetDataToSend (
 **/\r
 VOID\r
 SockNoMoreData (\r
-  IN SOCKET *Sock\r
+  IN OUT SOCKET *Sock\r
   );\r
 \r
 /**\r
@@ -345,9 +341,9 @@ SockNoMoreData (
 **/\r
 VOID\r
 SockDataRcvd (\r
-  IN SOCKET    *Sock,\r
-  IN NET_BUF   *NetBuffer,\r
-  IN UINT32    UrgLen\r
+  IN     SOCKET    *Sock,\r
+  IN OUT NET_BUF   *NetBuffer,\r
+  IN     UINT32    UrgLen\r
   );\r
 \r
 /**\r
@@ -389,8 +385,8 @@ SockClone (
 **/\r
 VOID\r
 SockRcvdErr (\r
-  IN SOCKET       *Sock,\r
-  IN EFI_STATUS   Error\r
+  IN OUT SOCKET       *Sock,\r
+  IN     EFI_STATUS   Error\r
   );\r
 \r
 ///\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Func.h b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Func.h
index b0edceaab9ac79d3e52b359b107caab17e1f149f..ae2c666bf2051cb6757be254cfddbd4015154a91 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Func.h
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Func.h
@@ -107,7 +107,7 @@ TcpGetIss (
 **/\r
 VOID\r
 TcpInitTcbLocal (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -121,9 +121,9 @@ TcpInitTcbLocal (
 **/\r
 VOID\r
 TcpInitTcbPeer (\r
-  IN TCP_CB     *Tcb,\r
-  IN TCP_SEG    *Seg,\r
-  IN TCP_OPTION *Opt\r
+  IN OUT TCP_CB     *Tcb,\r
+  IN     TCP_SEG    *Seg,\r
+  IN     TCP_OPTION *Opt\r
   );\r
 \r
 /**\r
@@ -148,8 +148,8 @@ TcpGetRcvMss (
 **/\r
 VOID\r
 TcpSetState (\r
-  IN TCP_CB      *Tcb,\r
-  IN UINT8       State\r
+  IN OUT TCP_CB    *Tcb,\r
+  IN     UINT8     State\r
   );\r
 \r
 //\r
@@ -187,8 +187,8 @@ TcpSendIpPacket (
 **/\r
 INTN\r
 TcpToSendData (\r
-  IN TCP_CB *Tcb,\r
-  IN INTN Force\r
+  IN OUT TCP_CB *Tcb,\r
+  IN     INTN Force\r
   );\r
 \r
 /**\r
@@ -199,7 +199,7 @@ TcpToSendData (
 **/\r
 VOID\r
 TcpToSendAck (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -210,7 +210,7 @@ TcpToSendAck (
 **/\r
 VOID\r
 TcpSendAck (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -224,7 +224,7 @@ TcpSendAck (
 **/\r
 INTN\r
 TcpSendZeroProbe (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -240,7 +240,7 @@ TcpSendZeroProbe (
 **/\r
 INTN\r
 TcpDeliverData (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -482,8 +482,8 @@ TcpSeqAcceptable (
 **/\r
 VOID\r
 TcpFastRecover (\r
-  IN TCP_CB  *Tcb,\r
-  IN TCP_SEG *Seg\r
+  IN OUT TCP_CB  *Tcb,\r
+  IN     TCP_SEG *Seg\r
   );\r
 \r
 /**\r
@@ -495,8 +495,8 @@ TcpFastRecover (
 **/\r
 VOID\r
 TcpFastLossRecover (\r
-  IN TCP_CB  *Tcb,\r
-  IN TCP_SEG *Seg\r
+  IN OUT TCP_CB  *Tcb,\r
+  IN     TCP_SEG *Seg\r
   );\r
 \r
 /**\r
@@ -508,8 +508,8 @@ TcpFastLossRecover (
 **/\r
 VOID\r
 TcpComputeRtt (\r
-  IN TCP_CB *Tcb,\r
-  IN UINT32 Measure\r
+  IN OUT TCP_CB *Tcb,\r
+  IN     UINT32 Measure\r
   );\r
 \r
 /**\r
@@ -534,8 +534,8 @@ TcpTrimInWnd (
 **/\r
 VOID\r
 TcpQueueData (\r
-  IN TCP_CB  *Tcb,\r
-  IN NET_BUF *Nbuf\r
+  IN OUT TCP_CB  *Tcb,\r
+  IN     NET_BUF *Nbuf\r
   );\r
 \r
 /**\r
@@ -583,8 +583,8 @@ TcpChecksum (
 **/\r
 TCP_SEG *\r
 TcpFormatNetbuf (\r
-  IN TCP_CB  *Tcb,\r
-  IN NET_BUF *Nbuf\r
+  IN     TCP_CB  *Tcb,\r
+  IN OUT NET_BUF *Nbuf\r
   );\r
 \r
 /**\r
@@ -596,7 +596,7 @@ TcpFormatNetbuf (
 **/\r
 VOID\r
 TcpOnAppConnect (\r
-  IN TCP_CB  *Tcb\r
+  IN OUT TCP_CB  *Tcb\r
   );\r
 \r
 /**\r
@@ -620,7 +620,7 @@ TcpOnAppConsume (
 **/\r
 VOID\r
 TcpOnAppClose (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -636,7 +636,7 @@ TcpOnAppClose (
 **/\r
 INTN\r
 TcpOnAppSend (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -674,7 +674,7 @@ TcpResetConnection (
 **/\r
 VOID\r
 TcpClose (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -701,9 +701,9 @@ TcpTicking (
 **/\r
 VOID\r
 TcpSetTimer (\r
-  IN TCP_CB *Tcb,\r
-  IN UINT16 Timer,\r
-  IN UINT32 TimeOut\r
+  IN OUT TCP_CB *Tcb,\r
+  IN     UINT16 Timer,\r
+  IN     UINT32 TimeOut\r
   );\r
 \r
 /**\r
@@ -715,8 +715,8 @@ TcpSetTimer (
 **/\r
 VOID\r
 TcpClearTimer (\r
-  IN TCP_CB *Tcb,\r
-  IN UINT16 Timer\r
+  IN OUT TCP_CB *Tcb,\r
+  IN     UINT16 Timer\r
   );\r
 \r
 /**\r
@@ -727,7 +727,7 @@ TcpClearTimer (
 **/\r
 VOID\r
 TcpClearAllTimer (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -738,7 +738,7 @@ TcpClearAllTimer (
 **/\r
 VOID\r
 TcpSetProbeTimer (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -749,7 +749,7 @@ TcpSetProbeTimer (
 **/\r
 VOID\r
 TcpSetKeepaliveTimer (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -760,7 +760,7 @@ TcpSetKeepaliveTimer (
 **/\r
 VOID\r
 TcpBackoffRto (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Input.c b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Input.c
index 8443f34e04b26c591156d2d304fb1364feb90844..14887a6ba2d3e8c8e4330ee842ce428a3e24696f 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Input.c
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Input.c
@@ -46,8 +46,8 @@ TcpSeqAcceptable (
 **/\r
 VOID\r
 TcpFastRecover (\r
-  IN TCP_CB  *Tcb,\r
-  IN TCP_SEG *Seg\r
+  IN OUT TCP_CB  *Tcb,\r
+  IN     TCP_SEG *Seg\r
   )\r
 {\r
   UINT32  FlightSize;\r
@@ -156,8 +156,8 @@ TcpFastRecover (
 **/\r
 VOID\r
 TcpFastLossRecover (\r
-  IN TCP_CB  *Tcb,\r
-  IN TCP_SEG *Seg\r
+  IN OUT TCP_CB  *Tcb,\r
+  IN     TCP_SEG *Seg\r
   )\r
 {\r
   if (TCP_SEQ_GT (Seg->Ack, Tcb->SndUna)) {\r
@@ -200,8 +200,8 @@ TcpFastLossRecover (
 **/\r
 VOID\r
 TcpComputeRtt (\r
-  IN TCP_CB *Tcb,\r
-  IN UINT32 Measure\r
+  IN OUT TCP_CB *Tcb,\r
+  IN     UINT32 Measure\r
   )\r
 {\r
   INT32 Var;\r
@@ -369,7 +369,7 @@ TcpTrimInWnd (
 **/\r
 INTN\r
 TcpDeliverData (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   LIST_ENTRY      *Entry;\r
@@ -533,8 +533,8 @@ TcpDeliverData (
 **/\r
 VOID\r
 TcpQueueData (\r
-  IN TCP_CB  *Tcb,\r
-  IN NET_BUF *Nbuf\r
+  IN OUT TCP_CB  *Tcb,\r
+  IN     NET_BUF *Nbuf\r
   )\r
 {\r
   TCP_SEG         *Seg;\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Io.c b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Io.c
index e7f0df90e9d981c0f9c380dc0056dc43f190b06e..963d730714c40c3d4c1364c334657024faac1276 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Io.c
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Io.c
@@ -26,8 +26,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
   @param  Context     Pointer to the context configured in IpIoOpen(), not used\r
                       now.\r
 \r
-  @return None\r
-\r
 **/\r
 VOID\r
 Tcp4RxCallback (\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Misc.c b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Misc.c
index 1b0ae5ec54b27a6bc51d3194ac93a2dc8070c6f3..1f478290bb4774ae7f696185663d36bc9fabda93 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Misc.c
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Misc.c
@@ -52,7 +52,7 @@ CHAR16   *mTcpStateName[] = {
 **/\r
 VOID\r
 TcpInitTcbLocal (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   //\r
@@ -92,9 +92,9 @@ TcpInitTcbLocal (
 **/\r
 VOID\r
 TcpInitTcbPeer (\r
-  IN TCP_CB     *Tcb,\r
-  IN TCP_SEG    *Seg,\r
-  IN TCP_OPTION *Opt\r
+  IN OUT TCP_CB     *Tcb,\r
+  IN     TCP_SEG    *Seg,\r
+  IN     TCP_OPTION *Opt\r
   )\r
 {\r
   UINT16  RcvMss;\r
@@ -496,8 +496,8 @@ TcpGetRcvMss (
 **/\r
 VOID\r
 TcpSetState (\r
-  IN TCP_CB      *Tcb,\r
-  IN UINT8       State\r
+  IN OUT TCP_CB  *Tcb,\r
+  IN     UINT8   State\r
   )\r
 {\r
   DEBUG (\r
@@ -578,8 +578,8 @@ TcpChecksum (
 **/\r
 TCP_SEG *\r
 TcpFormatNetbuf (\r
-  IN TCP_CB  *Tcb,\r
-  IN NET_BUF *Nbuf\r
+  IN     TCP_CB  *Tcb,\r
+  IN OUT NET_BUF *Nbuf\r
   )\r
 {\r
   TCP_SEG   *Seg;\r
@@ -674,7 +674,7 @@ TcpResetConnection (
 **/\r
 VOID\r
 TcpOnAppConnect (\r
-  IN TCP_CB  *Tcb\r
+  IN OUT TCP_CB  *Tcb\r
   )\r
 {\r
   TcpInitTcbLocal (Tcb);\r
@@ -694,7 +694,7 @@ TcpOnAppConnect (
 **/\r
 VOID\r
 TcpOnAppClose (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   ASSERT (Tcb != NULL);\r
@@ -745,29 +745,25 @@ TcpOnAppClose (
 **/\r
 INTN\r
 TcpOnAppSend (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
 \r
   switch (Tcb->State) {\r
   case TCP_CLOSED:\r
     return -1;\r
-    break;\r
 \r
   case TCP_LISTEN:\r
     return -1;\r
-    break;\r
 \r
   case TCP_SYN_SENT:\r
   case TCP_SYN_RCVD:\r
     return 0;\r
-    break;\r
 \r
   case TCP_ESTABLISHED:\r
   case TCP_CLOSE_WAIT:\r
     TcpToSendData (Tcb, 0);\r
     return 0;\r
-    break;\r
 \r
   case TCP_FIN_WAIT_1:\r
   case TCP_FIN_WAIT_2:\r
@@ -775,7 +771,7 @@ TcpOnAppSend (
   case TCP_LAST_ACK:\r
   case TCP_TIME_WAIT:\r
     return -1;\r
-    break;\r
+\r
   default:\r
     break;\r
   }\r
@@ -869,6 +865,8 @@ TcpOnAppAbort (
   case TCP_CLOSE_WAIT:\r
     TcpResetConnection (Tcb);\r
     break;\r
+  default:\r
+    break;\r
   }\r
 \r
   TcpSetState (Tcb, TCP_CLOSED);\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.c b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.c
index f321635323543dd174e3f240ba800929a5d4c394..39c16aff29f45627952e31a91f4edfe5aea372aa 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.c
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.c
@@ -59,8 +59,8 @@ TcpGetUint32 (
 **/\r
 VOID\r
 TcpPutUint32 (\r
-  IN UINT8  *Buf,\r
-  IN UINT32 Data\r
+     OUT UINT8  *Buf,\r
+  IN     UINT32 Data\r
   )\r
 {\r
   Data = HTONL (Data);\r
@@ -236,8 +236,8 @@ TcpBuildOption (
 **/\r
 INTN\r
 TcpParseOption (\r
-  IN TCP_HEAD   *Tcp,\r
-  IN TCP_OPTION *Option\r
+  IN     TCP_HEAD   *Tcp,\r
+  IN OUT TCP_OPTION *Option\r
   )\r
 {\r
   UINT8 *Head;\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.h b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.h
index 727c6f2dd4ba14710b50d5cd4b860b7e069b16a5..2caa1a4a05ecfd67cca788f1f460b259ac60bfd8 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.h
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.h
@@ -124,8 +124,8 @@ TcpBuildOption (
 **/\r
 INTN\r
 TcpParseOption (\r
-  IN TCP_HEAD   *Tcp,\r
-  IN TCP_OPTION *Option\r
+  IN     TCP_HEAD   *Tcp,\r
+  IN OUT TCP_OPTION *Option\r
   );\r
 \r
 /**\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Output.c b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Output.c
index 4d68c298ea37a75483a4bc6df7fee794629b7db9..c9a1f6b106aa9cd495490a08e73192a420f8b168 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Output.c
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Output.c
@@ -115,8 +115,8 @@ TcpRcvWinNow (
 **/\r
 UINT16\r
 TcpComputeWnd (\r
-  IN TCP_CB  *Tcb,\r
-  IN BOOLEAN Syn\r
+  IN OUT TCP_CB  *Tcb,\r
+  IN     BOOLEAN Syn\r
   )\r
 {\r
   UINT32  Wnd;\r
@@ -286,8 +286,8 @@ SetPersistTimer:
 **/\r
 INTN\r
 TcpTransmitSegment (\r
-  IN TCP_CB  *Tcb,\r
-  IN NET_BUF *Nbuf\r
+  IN OUT TCP_CB  *Tcb,\r
+  IN     NET_BUF *Nbuf\r
   )\r
 {\r
   UINT16    Len;\r
@@ -721,8 +721,8 @@ OnError:
 **/\r
 INTN\r
 TcpToSendData (\r
-  IN TCP_CB *Tcb,\r
-  IN INTN Force\r
+  IN OUT TCP_CB *Tcb,\r
+  IN     INTN Force\r
   )\r
 {\r
   UINT32    Len;\r
@@ -909,7 +909,7 @@ OnError:
 **/\r
 VOID\r
 TcpSendAck (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   NET_BUF *Nbuf;\r
@@ -948,7 +948,7 @@ TcpSendAck (
 **/\r
 INTN\r
 TcpSendZeroProbe (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   NET_BUF *Nbuf;\r
@@ -987,7 +987,7 @@ TcpSendZeroProbe (
 **/\r
 VOID\r
 TcpToSendAck (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   UINT32 TcpNow;\r

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Timer.c b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Timer.c
index 616e9e23ebf9d9703415556531afa9e80feac230..2d2c27614d3d0d6d0a9a71f785195b5cc7e4f3c7 100644 (file)
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Timer.c
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Timer.c
@@ -24,7 +24,7 @@ UINT32    mTcpTick = 1000;
 **/\r
 VOID\r
 TcpConnectTimeout (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -35,7 +35,7 @@ TcpConnectTimeout (
 **/\r
 VOID\r
 TcpRexmitTimeout (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
   \r
 /**\r
@@ -46,7 +46,7 @@ TcpRexmitTimeout (
 **/\r
 VOID\r
 TcpProbeTimeout (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -57,7 +57,7 @@ TcpProbeTimeout (
 **/\r
 VOID\r
 TcpKeepaliveTimeout (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -68,7 +68,7 @@ TcpKeepaliveTimeout (
 **/\r
 VOID\r
 TcpFinwait2Timeout (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 /**\r
@@ -79,7 +79,7 @@ TcpFinwait2Timeout (
 **/\r
 VOID\r
 Tcp2MSLTimeout (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   );\r
 \r
 TCP_TIMER_HANDLER mTcpTimerHandler[TCP_TIMER_NUMBER] = {\r
@@ -99,7 +99,7 @@ TCP_TIMER_HANDLER mTcpTimerHandler[TCP_TIMER_NUMBER] = {
 **/\r
 VOID\r
 TcpClose (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   NetbufFreeList (&Tcb->SndQue);\r
@@ -117,7 +117,7 @@ TcpClose (
 **/\r
 VOID\r
 TcpConnectTimeout (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   if (!TCP_CONNECTED (Tcb->State)) {\r
@@ -149,7 +149,7 @@ TcpConnectTimeout (
 **/\r
 VOID\r
 TcpRexmitTimeout (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   UINT32  FlightSize;\r
@@ -200,7 +200,7 @@ TcpRexmitTimeout (
 **/\r
 VOID\r
 TcpProbeTimeout (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   //\r
@@ -228,7 +228,7 @@ TcpProbeTimeout (
 **/\r
 VOID\r
 TcpKeepaliveTimeout (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   Tcb->KeepAliveProbes++;\r
@@ -259,7 +259,7 @@ TcpKeepaliveTimeout (
 **/\r
 VOID\r
 TcpFinwait2Timeout (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   DEBUG ((EFI_D_WARN, "TcpFinwait2Timeout: connection closed "\r
@@ -277,7 +277,7 @@ TcpFinwait2Timeout (
 **/\r
 VOID\r
 Tcp2MSLTimeout (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   DEBUG ((EFI_D_WARN, "Tcp2MSLTimeout: connection closed "\r
@@ -296,7 +296,7 @@ Tcp2MSLTimeout (
 **/\r
 VOID\r
 TcpUpdateTimer (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   UINT16  Index;\r
@@ -330,9 +330,9 @@ TcpUpdateTimer (
 **/\r
 VOID\r
 TcpSetTimer (\r
-  IN TCP_CB *Tcb,\r
-  IN UINT16 Timer,\r
-  IN UINT32 TimeOut\r
+  IN OUT TCP_CB *Tcb,\r
+  IN     UINT16 Timer,\r
+  IN     UINT32 TimeOut\r
   )\r
 {\r
   TCP_SET_TIMER (Tcb->EnabledTimer, Timer);\r
@@ -351,8 +351,8 @@ TcpSetTimer (
 **/\r
 VOID\r
 TcpClearTimer (\r
-  IN TCP_CB *Tcb,\r
-  IN UINT16 Timer\r
+  IN OUT TCP_CB *Tcb,\r
+  IN     UINT16 Timer\r
   )\r
 {\r
   TCP_CLEAR_TIMER (Tcb->EnabledTimer, Timer);\r
@@ -368,7 +368,7 @@ TcpClearTimer (
 **/\r
 VOID\r
 TcpClearAllTimer (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   Tcb->EnabledTimer = 0;\r
@@ -384,7 +384,7 @@ TcpClearAllTimer (
 **/\r
 VOID\r
 TcpSetProbeTimer (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   if (!TCP_TIMER_ON (Tcb->EnabledTimer, TCP_TIMER_PROBE)) {\r
@@ -414,7 +414,7 @@ TcpSetProbeTimer (
 **/\r
 VOID\r
 TcpSetKeepaliveTimer (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   if (TCP_FLG_ON (Tcb->CtrlFlag, TCP_CTRL_NO_KEEPALIVE)) {\r
@@ -450,7 +450,7 @@ TcpSetKeepaliveTimer (
 **/\r
 VOID\r
 TcpBackoffRto (\r
-  IN TCP_CB *Tcb\r
+  IN OUT TCP_CB *Tcb\r
   )\r
 {\r
   //\r
@@ -553,6 +553,10 @@ TcpTickingDpc (
         }\r
       }\r
     }\r
+    \r
+    //\r
+    // If the Tcb still exist or some timer is set, update the timer\r
+    //\r
     if (Index == TCP_TIMER_NUMBER) {\r
       TcpUpdateTimer (Tcb);\r
     }\r