MdeModulePkg/DxeCore: Fix coding style issues

Add comments for functions.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>

diff --git a/MdeModulePkg/Core/Dxe/Mem/Pool.c b/MdeModulePkg/Core/Dxe/Mem/Pool.c
index 5248ee2e6c0221cc2fbd713078b2a4a621c03da0..dd165fea756ed9997323a9f2329f003fe1fbb569 100644 (file)
--- a/MdeModulePkg/Core/Dxe/Mem/Pool.c
+++ b/MdeModulePkg/Core/Dxe/Mem/Pool.c
@@ -291,6 +291,17 @@ CoreAllocatePool (
   return Status;\r
 }\r
 \r
+/**\r
+  Internal function.  Used by the pool functions to allocate pages\r
+  to back pool allocation requests.\r
+\r
+  @param  PoolType               The type of memory for the new pool pages\r
+  @param  NoPages                No of pages to allocate\r
+  @param  Granularity            Bits to align.\r
+\r
+  @return The allocated memory, or NULL\r
+\r
+**/\r
 STATIC\r
 VOID *\r
 CoreAllocatePoolPagesI (\r
@@ -553,6 +564,14 @@ CoreFreePool (
   return Status;\r
 }\r
 \r
+/**\r
+  Internal function.  Frees pool pages allocated via CoreAllocatePoolPagesI().\r
+\r
+  @param  PoolType               The type of memory for the pool pages\r
+  @param  Memory                 The base address to free\r
+  @param  NoPages                The number of pages to free\r
+\r
+**/\r
 STATIC\r
 VOID\r
 CoreFreePoolPagesI (\r

diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
index 070228bc7265685b911d7f54f258900d1eef7ece..7689c794a8ad22601965303e4dfce255e3923c09 100644 (file)
--- a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
+++ b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
@@ -657,6 +657,8 @@ UnprotectUefiImage (
 /**\r
   Return the EFI memory permission attribute associated with memory\r
   type 'MemoryType' under the configured DXE memory protection policy.\r
+\r
+  @param MemoryType       Memory type.\r
 **/\r
 STATIC\r
 UINT64\r
@@ -788,7 +790,7 @@ MergeMemoryMapForProtectionPolicy (
 \r
 /**\r
   Remove exec permissions from all regions whose type is identified by\r
-  PcdDxeNxMemoryProtectionPolicy\r
+  PcdDxeNxMemoryProtectionPolicy.\r
 **/\r
 STATIC\r
 VOID\r
@@ -1053,7 +1055,7 @@ CoreInitializeMemoryProtection (
 }\r
 \r
 /**\r
-  Returns whether we are currently executing in SMM mode\r
+  Returns whether we are currently executing in SMM mode.\r
 **/\r
 STATIC\r
 BOOLEAN\r