StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu

Bugzilla: 3150 (https://bugzilla.tianocore.org/show_bug.cgi?id=3150)

Fix the ECC reported error "[4002] Function header doesn't exist".

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
index 03e887d777ea0ca67b323dc5dfcab8249d5e7f42..d86d21bb013ce3a9749cdf92bf950091df455537 100644 (file)
--- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
+++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
@@ -196,10 +196,13 @@ MmFoundationEntryRegister (
   This function is the main entry point for an MM handler dispatch\r
   or communicate-based callback.\r
 \r
-  @param  DispatchHandle  The unique handle assigned to this handler by MmiHandlerRegister().\r
-  @param  Context         Points to an optional handler context which was specified when the handler was registered.\r
+  @param  DispatchHandle  The unique handle assigned to this handler by\r
+                          MmiHandlerRegister().\r
+  @param  Context         Points to an optional handler context which was\r
+                          specified when the handler was registered.\r
   @param  CommBuffer      A pointer to a collection of data in memory that will\r
-                          be conveyed from a non-MM environment into an MM environment.\r
+                          be conveyed from a non-MM environment into an\r
+                          MM environment.\r
   @param  CommBufferSize  The size of the CommBuffer.\r
 \r
   @return Status Code\r

diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
index 9e496096018da80aa8e7fe84721b1fa757a0b3ce..6884095c49f27f32db3f42888f685fdc0c0e6a89 100644 (file)
--- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
+++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
@@ -44,6 +44,16 @@ EFI_MM_SYSTEM_TABLE *mMmst = NULL;
 //\r
 STATIC EFI_HANDLE            mMmCpuHandle = NULL;\r
 \r
+/** Returns the HOB data for the matching HOB GUID.\r
+\r
+  @param  [in]  HobList  Pointer to the HOB list.\r
+  @param  [in]  HobGuid  The GUID for the HOB.\r
+  @param  [out] HobData  Pointer to the HOB data.\r
+\r
+  @retval  EFI_SUCCESS            The function completed successfully.\r
+  @retval  EFI_INVALID_PARAMETER  Invalid parameter.\r
+  @retval  EFI_NOT_FOUND          Could not find HOB with matching GUID.\r
+**/\r
 EFI_STATUS\r
 GetGuidedHobData (\r
   IN  VOID *HobList,\r
@@ -70,9 +80,20 @@ GetGuidedHobData (
   return EFI_SUCCESS;\r
 }\r
 \r
+/** Entry point for the Standalone MM CPU driver.\r
+\r
+  @param  [in]  ImageHandle   Unused. Not actual image handle.\r
+  @param  [in]  SystemTable   Pointer to MM System table.\r
+\r
+  @retval  EFI_SUCCESS            The function completed successfully.\r
+  @retval  EFI_INVALID_PARAMETER  Invalid parameter.\r
+  @retval  EFI_OUT_OF_RESOURCES   Out of resources.\r
+  @retval  EFI_NOT_FOUND          Failed to find the HOB for the CPU\r
+                                  driver endpoint descriptor.\r
+**/\r
 EFI_STATUS\r
 StandaloneMmCpuInitialize (\r
-  IN EFI_HANDLE         ImageHandle,  // not actual imagehandle\r
+  IN EFI_HANDLE            ImageHandle,  // not actual imagehandle\r
   IN EFI_MM_SYSTEM_TABLE   *SystemTable  // not actual systemtable\r
   )\r
 {\r

diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h
index 47a020c27b9591436d0559f34e0dcd0e7443aa93..2c96439c1587020e9a130cfb53bb51a144fc485b 100644 (file)
--- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h
+++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h
@@ -2,7 +2,7 @@
   Private header with declarations and definitions specific to the MM Standalone\r
   CPU driver\r
 \r
-  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.\r
+  Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.\r
   SPDX-License-Identifier: BSD-2-Clause-Patent\r
 \r
 **/\r
@@ -33,6 +33,19 @@ extern EFI_MMRAM_DESCRIPTOR          mNsCommBuffer;
 extern MP_INFORMATION_HOB_DATA       *mMpInformationHobData;\r
 extern EFI_MM_CONFIGURATION_PROTOCOL mMmConfig;\r
 \r
+/**\r
+  The PI Standalone MM entry point for the TF-A CPU driver.\r
+\r
+  @param  [in] EventId            The event Id.\r
+  @param  [in] CpuNumber          The CPU number.\r
+  @param  [in] NsCommBufferAddr   Address of the NS common buffer.\r
+\r
+  @retval   EFI_SUCCESS             Success.\r
+  @retval   EFI_INVALID_PARAMETER   A parameter was invalid.\r
+  @retval   EFI_ACCESS_DENIED       Access not permitted.\r
+  @retval   EFI_OUT_OF_RESOURCES    Out of resources.\r
+  @retval   EFI_UNSUPPORTED         Operation not supported.\r
+**/\r
 EFI_STATUS\r
 PiMmStandaloneArmTfCpuDriverEntry (\r
   IN UINTN EventId,\r
@@ -40,6 +53,22 @@ PiMmStandaloneArmTfCpuDriverEntry (
   IN UINTN NsCommBufferAddr\r
   );\r
 \r
+/**\r
+  This function is the main entry point for an MM handler dispatch\r
+  or communicate-based callback.\r
+\r
+  @param  DispatchHandle  The unique handle assigned to this handler by\r
+                          MmiHandlerRegister().\r
+  @param  Context         Points to an optional handler context which was\r
+                          specified when the handler was registered.\r
+  @param  CommBuffer      A pointer to a collection of data in memory that will\r
+                          be conveyed from a non-MM environment into an\r
+                          MM environment.\r
+  @param  CommBufferSize  The size of the CommBuffer.\r
+\r
+  @return Status Code\r
+\r
+**/\r
 EFI_STATUS\r
 EFIAPI\r
 PiMmCpuTpFwRootMmiHandler (\r