]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdeModulePkg/SetupBrowser:Don't support password without interactive flag
authorDandan Bi <dandan.bi@intel.com>
Tue, 15 Nov 2016 11:13:33 +0000 (19:13 +0800)
committerStar Zeng <star.zeng@intel.com>
Fri, 25 Nov 2016 02:50:26 +0000 (10:50 +0800)
In current SetupBrowser, the logic related to non-interative password
is not correct. How to support it correctly or whether support it
is still under investigation. First step remove the incorrect logic.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
MdeModulePkg/Universal/SetupBrowserDxe/Setup.c

index 754781457501e0f6577a4f8469fa21caf02d838a..451fd037073cf8caf85cf39037f8abce2dde1ff2 100644 (file)
@@ -6108,29 +6108,10 @@ PasswordCheck (
       return EFI_UNSUPPORTED;\r
     }\r
   } else {\r
-    if (PasswordString == NULL) {\r
-      return EFI_SUCCESS;\r
-    } \r
-\r
-    //\r
-    // Check whether has preexisted password.\r
-    //\r
-    if (PasswordString[0] == 0) {\r
-      if (*((CHAR16 *) Question->BufferValue) == 0) {\r
-        return EFI_SUCCESS;\r
-      } else {\r
-        return EFI_NOT_READY;\r
-      }\r
-    }\r
-\r
     //\r
-    // Check whether the input password is same as preexisted password.\r
+    // If a password doesn't have the CALLBACK flag, browser will not handle it.\r
     //\r
-    if (StrnCmp (PasswordString, (CHAR16 *) Question->BufferValue, Question->StorageWidth/sizeof (CHAR16)) == 0) {\r
-      return EFI_SUCCESS;\r
-    } else {\r
-      return EFI_NOT_READY;\r
-    }\r
+    return EFI_UNSUPPORTED;\r
   }\r
     \r
   //\r