]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdeModulePkg: Convert HiiDatabaseDxe ConfigRouting ASSERT to return an error
authorEugene Cohen <eugene@hp.com>
Fri, 11 Dec 2015 03:07:59 +0000 (03:07 +0000)
committerydong10 <ydong10@Edk2>
Fri, 11 Dec 2015 03:07:59 +0000 (03:07 +0000)
This should just return an error and not assert.  We hit this when testing with a client that was trying to access the old IP4_CONFIG on firmware implementing IP4_CONFIG2.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eugene Cohen <eugene@hp.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19219 6f19259b-4bc3-4df7-8a09-765794883524

MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c

index b618903b6a5bd2c2615d40f2a85ad43eaa492f5a..55ac08cedb29859a7b55858f8bf18e7b2f0c388e 100644 (file)
@@ -3873,7 +3873,9 @@ HiiConfigRoutingExtractConfig (
                       &gEfiHiiConfigAccessProtocolGuid,\r
                       (VOID **) &ConfigAccess\r
                       );\r
                       &gEfiHiiConfigAccessProtocolGuid,\r
                       (VOID **) &ConfigAccess\r
                       );\r
-      ASSERT_EFI_ERROR (Status);\r
+      if (EFI_ERROR (Status)) {\r
+        goto Done;\r
+      }\r
 \r
       Status = ConfigAccess->ExtractConfig (\r
                                ConfigAccess,\r
 \r
       Status = ConfigAccess->ExtractConfig (\r
                                ConfigAccess,\r